944702 - Tracelogger: Add hints about what sort of thread the logger is logging

Status: RESOLVED DUPLICATE of bug 1296878

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

We have different types of threads running:
- mainThread
- background GC thread
- background Compile thread
- ...

Currently tracelogger can't really distinguish them and it would be good for the UI to have some idea what the different files contain.

Comment 1

[Wei Wu [:wuwei UTC+8]]

(In reply to Hannes Verschore [:h4writer] from comment #0)
> We have different types of threads running:
> - mainThread
> - background GC thread
> - background Compile thread
> - ...
> 
> Currently tracelogger can't really distinguish them and it would be good for
> the UI to have some idea what the different files contain.

Hi, is this feature still needed? I'm happy to implement it if you think worth.

Comment 2

[Wei Wu [:wuwei UTC+8]]

(In reply to Wei Wu [:w :wuwei UTC+8] from comment #1)
> (In reply to Hannes Verschore [:h4writer] from comment #0)
> > We have different types of threads running:
> > - mainThread
> > - background GC thread
> > - background Compile thread
> > - ...
> > 
> > Currently tracelogger can't really distinguish them and it would be good for
> > the UI to have some idea what the different files contain.
> 
> Hi, is this feature still needed? I'm happy to implement it if you think
> worth.

Discussed on IRC. I'll try to submit a patch.

Comment 3

[Wei Wu [:wuwei UTC+8]]

According to bug 931151, I think I need to import 'PR_GetThreadName' into PosixNSPR.{h,cpp}

Comment 4

[Wei Wu [:wuwei UTC+8]]

(In reply to Wei Wu [:w :wuwei UTC+8] from comment #3)
> According to bug 931151, I think I need to import 'PR_GetThreadName' into
> PosixNSPR.{h,cpp}

First try: use TheadName prop:
https://dxr.mozilla.org/mozilla-central/search?q=PR_SetCurrentThreadName%28%22&redirect=false&case=true

Comment 5

[Wei Wu [:wuwei UTC+8]]

> [{"tree":"tl-tree.0.tl", "events":"tl-event.0.tl", "dict":"tl-dict.0.json", "treeFormat":"64,64,31,1,32", "Main Thread"},
> {"tree":"tl-tree.1.tl", "events":"tl-event.1.tl", "dict":"tl-dict.1.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.2.tl", "events":"tl-event.2.tl", "dict":"tl-dict.2.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.3.tl", "events":"tl-event.3.tl", "dict":"tl-dict.3.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.4.tl", "events":"tl-event.4.tl", "dict":"tl-dict.4.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.5.tl", "events":"tl-event.5.tl", "dict":"tl-dict.5.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.6.tl", "events":"tl-event.6.tl", "dict":"tl-dict.6.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.7.tl", "events":"tl-event.7.tl", "dict":"tl-dict.7.json", "treeFormat":"64,64,31,1,32", "JS Helper"},
> {"tree":"tl-tree.8.tl", "events":"tl-event.8.tl", "dict":"tl-dict.8.json", "treeFormat":"64,64,31,1,32", "JS Helper"}]

Hm, seems indistinguishable.

Comment 6

[Wei Wu [:wuwei UTC+8]]

Attachment: WIP

WIP version for feedback.
seems we don't set thread name when we use helper threads for off thread compilation or gc, i'd like to implement it it the idea of using thread name is feasible.
A few func signatures were changed, not sure the feasibility neither.

Comment 7

[Wei Wu [:wuwei UTC+8]]

https://dxr.mozilla.org/mozilla-central/source/js/src/vm/HelperThreads.cpp#1576-1596

Seems that in SM GC thread, Ion thread and AsmJS thread are unified.
so the thread name in SM may not be feasible.