Closed Bug 944717 Opened 10 years ago Closed 10 years ago

Test failure "Successfully restarted in 32bit mode after requesting it - 'x86_64-gcc3' should equal 'x86-gcc3'" in /restartTests/testRestartChangeArchitecture/test3.js


(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)



(firefox25 unaffected, firefox26 unaffected, firefox27 unaffected, firefox28 fixed, firefox29 fixed, firefox-esr17 unaffected, firefox-esr24 unaffected)

Tracking Status
firefox25 --- unaffected
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 --- fixed
firefox29 --- fixed
firefox-esr17 --- unaffected
firefox-esr24 --- unaffected


(Reporter: mario.garbi, Assigned: whimboo)




(Whiteboard: [mozmill-test-failure])


(3 files, 1 obsolete file)

Something clearly changed in mozilla-central between the 28th and 29th of November.

mozilla-central pushlog:

We have 2 merges from fx-team and 1 from inbound. I'll narrow this down with tinderbox builds.

Interestingly this doesn't fail with mozmill 2.0
Pushlog from fx-team:

I can't see how any of these changes could affect OSX restart flags...
I have doublechecked the builds I've tested, and this pushlog appears to be valid.
Please continue your regression tests. It's not done yet and those builds should still exist.
The referenced pushlog in comment 2 is from _consecutive_ tinderbox builds from fx-team.

I took them from and the mentioned builds are:

1385679919 good
1385687659 bad

I'm not sure why there aren't tinderbox builds for each commit here.
Attached patch skip.patchSplinter Review
This fails a lot, and it seems that most of the tests failing with this error fails to send report document, so I think we should skip the tests ASAP.
Attachment #8341065 - Flags: review?(andreea.matei)
This was a single push as you can see only one user. So you will have to build Firefox then.
(In reply to Cosmin Malutan from comment #5)
> This fails a lot, and it seems that most of the tests failing with this
> error fails to send report document, so I think we should skip the tests

Both have absolutely nothing to do with each other.
Comment on attachment 8341065 [details] [diff] [review]

Review of attachment 8341065 [details] [diff] [review]:

Skipped: (default)
Attachment #8341065 - Flags: review?(andreea.matei) → review+
I've build Firefox on OSX several time already, but I haven't been able to have a `universal binary`.

I'm still tweaking the build options to have a correct build that supports both 32b and 64b architecture. I've looked at both and compared the compile flags from about:buildconfig
We should wait for bug 960509 being fixed before continuing the investigation.
Depends on: 960509
Andrei, I think we can re-enable those tests, also given that those were always working with Mozmill 2.0.
Flags: needinfo?(andrei.eftimie)
Attached patch 1.patch (obsolete) — Splinter Review
Great news.
I am unable to reproduce these failures at all with mozmill 2

Unskip patch attached.
Sample testrun:

I'll check the other branches shortly
Assignee: nobody → andrei.eftimie
Attachment #8367197 - Flags: review?(andreea.matei)
Flags: needinfo?(andrei.eftimie)
Attached patch 1.1.patchSplinter Review
Applies cleanly to default and mozilla-aurora
Only those branches have had these tests skipped.

Small update to enable the tests in the manifest only for OSX
Attachment #8367197 - Attachment is obsolete: true
Attachment #8367197 - Flags: review?(andreea.matei)
Attachment #8367199 - Flags: review?(andreea.matei)
Comment on attachment 8367199 [details] [diff] [review]

Review of attachment 8367199 [details] [diff] [review]:

Why do we need a new patch for unskipping the test? We can simply backout. I do not see any differences in a local diff. Beside this the commit message should also contain better information which tests you re-enable.
Attachment #8367199 - Flags: review?(andreea.matei) → review-
Backed-out the skip patch on default and will do the same on other branches if no failures are present today.
I'm not sure why we change the disabled line in the manifest for aurora but because of that difference to default, I cannot backout the patch. Andrei, can you please review?
Assignee: andrei.eftimie → hskupin
Attachment #8369095 - Flags: review?(andrei.eftimie)
Comment on attachment 8369095 [details] [diff] [review]
Unskip (aurora) v1

Review of attachment 8369095 [details] [diff] [review]:

Looks good.
Attachment #8369095 - Flags: review?(andrei.eftimie) → review+
Also landed on aurora, so the test is enabled across all platforms:
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Henrik Skupin (:whimboo) from comment #18)
> Also landed on aurora, so the test is enabled across all platforms:

This missed the correct flag to only run tests on OSX in the manifest file.
I've fixed this during the merge in bug 964172
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.