944719 - color swatches do not update if you changed them

Status: RESOLVED DUPLICATE of bug 942297

(DevTools :: Inspector, defect)

Description

[sjw]

Attachment: testcase

If you change a color using the doorhanger from bug 889638, the swatches will not update when you select another element.

Comment 1

[Patrick Brosset <:pbro>]

I was able to reproduce that problem with the provided testcase, indeed, the STR are:
- open the testcase
- select any of the 3 elements
- change the color in the rule-view using the color picker
- then select another element

=> the color swatch has the color you just picked, not the one defined for the element.

Comment 2

[Patrick Brosset <:pbro>]

I just tested with colors defined via a CSS class rather than in the style attribute directly => No problem there. So it's something to do with the way we generate color swatches in the "element {}" part of the rule view.

Comment 3

[Patrick Brosset <:pbro>]

One more test revealed that this has nothing to do with color swatches, in fact any modified style in the "element {...}" part will stay even if you select another element.

Also, the modification will survive page reloads: change the value of a declaration in the style attribute, and then press F5 with the toolbox still opened => the changed value is still there.

Comment 4

[Patrick Brosset <:pbro>]

Brian, this seems to be the same bug you fixed a couple of weeks ago, although I couldn't find it.

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Patrick Brosset [:pbrosset] from comment #4)
> Brian, this seems to be the same bug you fixed a couple of weeks ago,
> although I couldn't find it.

It is Bug 942297, but I haven't fixed it.

Comment 6

[Patrick Brosset <:pbro>]

I confirm this is a dup of bug 942297.