944723 - [traceback] AttributeError: 'NoneType' object has no attribute 'isdigit'

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Mathieu Pillard [:mat]]

STR:
- Log in with admin rights
- Try to see an app that is not available in your region

(For reference: it happened to me on stage with https://marketplace.allizom.org/app/pricetier2 in worldwide region - the corresponding error in sentry is http://sentry.dmz.phx1.mozilla.com/addons/marketplace-stage/group/17249/ )

Expected results:
- See the app

Actual results:
- "Oh noes", with the API returning a 500 error for the app. The traceback:

AttributeError: 'NoneType' object has no attribute 'isdigit'

Stacktrace (most recent call last):

  File "rest_framework/views.py", line 396, in dispatch
    response = handler(request, *args, **kwargs)
  File "rest_framework/mixins.py", line 104, in retrieve
    self.object = self.get_object()
  File "mkt/webapps/api.py", line 424, in get_object
    app = super(AppViewSet, self).get_object(self.get_base_queryset())
  File "mkt/api/base.py", line 567, in get_object
    if 'pk' in self.kwargs and not self.kwargs['pk'].isdigit():

Comment 1

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/ea7103772d9ffed8cb21fc03a6f69608f882b1db

Comment 2

[Victor Carciu]

Verified as fixed : http://screencast.com/t/pOPohZSRwPp