944801 - Collect UITelemetry on how many links are opened from the bookmarks menu button

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

In order to measure bookmarks menu button usage, we want to count how many links are opened from it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 - for non-Australis

BMB_bookmarksPopup:child should match any bookmark opened under the bookmarks menu button.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks Gijs! Landed on Holly as https://hg.mozilla.org/projects/holly/rev/b55bba3d7f25

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8346104 [details] [diff] [review]
Patch v1 - for non-Australis

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

None. This gives BrowserUITelemetry the capability to count how many times bookmarks are opened from the bookmarks menu button.

User impact if declined: 

None.


Testing completed (on m-c, etc.): 

Only manual testing.


Risk to taking this patch (and alternatives if risky): 

None.


String or IDL/UUID changes made by this patch:

None.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Removing Australis:P1 whiteboard tag because these already block an Australis:P1 and being redundant isn't helpful.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed in mozilla-beta as https://hg.mozilla.org/releases/mozilla-beta/rev/262bd97fdd8c

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed in mozilla-aurora as https://hg.mozilla.org/releases/mozilla-aurora/rev/38cc1844cd2f

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 - for Australis

So it turns out this was remarkably easy. One caveat is that sometimes mouseups are fired for the "arrow" of the panel when after clicking on the dropmarker.

It's possible Enn's patch in bug 941409 will fix this, but if not, we're going to have to address this somehow. Worst case scenario, we'll need to subtract menu button clicks from the BMB_bookmarksPopup click count.

I'll file a separate bug for that.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8361676 [details] [diff] [review]
Patch v1 - for Australis

Almost... there...

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Thanks!

remote: https://hg.mozilla.org/integration/fx-team/rev/736fa1afd493

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/736fa1afd493

Comment 11

[svbabukumar]

[bugday-20140122]  - Could you please provide the exact STR(Steps to Reproduce) to check for fixed

Comment 12

[Mike Conley (:mconley) (:⚙️)]

(In reply to svbabukumar from comment #11)
> [bugday-20140122]  - Could you please provide the exact STR(Steps to
> Reproduce) to check for fixed

Sure, here goes:

1) In Nightly, open about:telemetry and ensure Telemetry is enabled. If not, enable and restart the browser.
2) Click on the right side of the Bookmarks menu button to bring up the list of bookmarks.
3) Click on a bookmark.
4) Repeat steps 2 and 3 any number of times
5) Open about:telemetry, and expand the "Simple Measurements" section.
6) There should be a row labeled "UITelemetry". On the right half of that row is a big JSON blob. You're looking for and entry in that blob called "BMB_bookmarksPopup". The entry should be a key, mapped to an object that will hold the count of how many times a bookmark has been clicked from the popup with each mouse button.

So, for example, if you clicked on 15 bookmarks in the popup with the left mouse button, and right-clicked one of those bookmarks once, you'd see:

BMB_bookmarksPopup: {
  left: 15,
  right: 1
}

And that's it!

Let me know if you have more questions.