944825 - Relaunch in Windows 8 style nightly should prompt for default on Holly if not already default.

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Brian R. Bondy [:bbondy]]

Holly's menu item for Relaunch in Windows 8 style Nightly should prompt for default if not already default.


Basically do the exact same thing you're already doing with the Australis front end code.

The code on Holly is what's going to be uplifted to Aurora.

p=1

Comment 1

[Marina Samuel [:emtwo]]

Attachment: v1: Prompt for default when attempting to switch to Metro

Also added a check to hide the button if not in win8.

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8341239 [details] [diff] [review]
v1: Prompt for default when attempting to switch to Metro

Review of attachment 8341239 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +2513,5 @@
> +  let isDefault = shell.isDefaultBrowser(false, false);
> +
> +  if (isDefault) {
> +    let appStartup = Components.classes["@mozilla.org/toolkit/app-startup;1"].
> +    getService(Components.interfaces.nsIAppStartup);

nit: indent getService

@@ +2515,5 @@
> +  if (isDefault) {
> +    let appStartup = Components.classes["@mozilla.org/toolkit/app-startup;1"].
> +    getService(Components.interfaces.nsIAppStartup);
> +
> +    Services.prefs.setBoolPref('browser.sessionstore.resume_session_once', true);

nit: use " since you use it for the other strings.

Comment 3

[Marina Samuel [:emtwo]]

https://tbpl.mozilla.org/?tree=Holly&rev=ab1336aaf9db

Comment 4

[Marina Samuel [:emtwo]]

Meant to post this:
https://hg.mozilla.org/projects/holly/rev/ab1336aaf9db

Comment 5

[Marina Samuel [:emtwo]]

Does this need to land anywhere else or can we close out the bug?

Comment 6

[Brian R. Bondy [:bbondy]]

I don't think so, I think we already prompt for it on m-c Australis. Feel free to close.