Closed Bug 944871 Opened 7 years ago Closed 7 years ago

Add localization comment to "Firefox Touch" string

Categories

(Firefox for Metro Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/88b60ad4d8c6

> firefoxTouchTitle=Firefox Touch

I had to find the bug and read half of the comments to understand what this is about. String needs a localization comment to explain where it's used.
Does this describe it correctly? I tried the last nightly on Windows 8.1 but Metro is stuck, so I couldn't really verify (but I see the folder in my bookmarks).

# LOCALIZATION NOTE (firefoxTouchTitle): this is the name of the folder used
# to store bookmarks created in Metro mode and share bookmarks between Metro
# and Desktop.
yep that string description sounds good.

Please post about the 'stuck' issue and we can troubleshoot in that bug. Thanks!
Attached patch bug944871.patchSplinter Review
Patch to add l10n comment.

Not sure it's relevant to post in that bug (it may be unrelated, Metro can't get past the splash screen). I'll test again on Win 8.1 and Win 8 and eventually open a new bug.
Assignee: nobody → francesco.lodolo
Attachment #8340630 - Flags: review?(netzen)
Attachment #8340630 - Flags: review?(netzen) → review+
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/d55d9500d535
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.