Closed
Bug 944871
Opened 11 years ago
Closed 11 years ago
Add localization comment to "Firefox Touch" string
Categories
(Firefox for Metro Graveyard :: General, defect)
Firefox for Metro Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
1.13 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/88b60ad4d8c6 > firefoxTouchTitle=Firefox Touch I had to find the bug and read half of the comments to understand what this is about. String needs a localization comment to explain where it's used.
Assignee | ||
Comment 1•11 years ago
|
||
Does this describe it correctly? I tried the last nightly on Windows 8.1 but Metro is stuck, so I couldn't really verify (but I see the folder in my bookmarks). # LOCALIZATION NOTE (firefoxTouchTitle): this is the name of the folder used # to store bookmarks created in Metro mode and share bookmarks between Metro # and Desktop.
Comment 2•11 years ago
|
||
yep that string description sounds good. Please post about the 'stuck' issue and we can troubleshoot in that bug. Thanks!
Assignee | ||
Comment 3•11 years ago
|
||
Patch to add l10n comment. Not sure it's relevant to post in that bug (it may be unrelated, Metro can't get past the splash screen). I'll test again on Win 8.1 and Win 8 and eventually open a new bug.
Assignee: nobody → francesco.lodolo
Attachment #8340630 -
Flags: review?(netzen)
Updated•11 years ago
|
Attachment #8340630 -
Flags: review?(netzen) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d55d9500d535
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d55d9500d535
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•