944913 - Fix char16_t/wchar_t mismatch in tollkit/.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jacek Caban]

Attachment: patch.diff

This is followup of bug 928351 for toolkit/.

Comment 1

[(no longer active)]

Comment on attachment 8340657 [details] [diff] [review]
patch.diff

Review of attachment 8340657 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsNativeAppSupportWin.cpp
@@ +642,5 @@
>  
>      // Grab mutex first.
>  
>      // Build mutex name from app name.
> +    ::_snwprintf(reinterpret_cast<wchar_t*>(mMutexName), sizeof mMutexName / sizeof(PRUnichar), L"%s%s%s",

Nit: please add a line break after the first argument.

@@ +1217,5 @@
>      nsAutoString temp;
>      // Ensure result's buffer is sufficiently big.
>      temp.SetLength( argLen );
>      // Now get the string contents.
> +    DdeQueryString( mInstance, args, (wchar_t*)temp.BeginWriting(), temp.Length(), CP_WINUNICODE );

Nit: reinterpret_cast

Comment 2

[Jacek Caban]

Committed with nits fixed. Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a41081c1026c

Comment 3

[Jacek Caban]

Partial revert due to build bustage on some platforms. That should be easy to fix, I will work on it later.

https://hg.mozilla.org/integration/mozilla-inbound/rev/933c28b72a55

Comment 4

[Jacek Caban]

Attachment: toolkit/crashreporter part

It seems like CONVERT_UTF16_TO_XP_CHAR is not worth the problem and confused me in the last try. Here is a new version.

https://tbpl.mozilla.org/?tree=Try&rev=fd327560f46a

Comment 5

[Jacek Caban]

Attachment: toolkit/crashreporter part

Fixed a typo:
https://tbpl.mozilla.org/?tree=Try&rev=41a918e92572

Comment 6

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f56bfb99d971

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f56bfb99d971