944932 - improve location of place markers on new Mozilla spaces pages

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The new Mozilla space pages from bug 897082 are very nice.  But a few of the markers could be moved ever so slightly to be more accurate pointers to where the office entrances are.  Assuming that the markers are intended to have their pointer pointing at the entrance, then:

http://www.mozilla.org/en-US/contact/spaces/paris/ should be 2.341210,48.871951 to match http://www.openstreetmap.org/node/1242530433 and thus be centered correctly with the door (and the kitchen bridge across the courtyard)

http://www.mozilla.org/en-US/contact/spaces/taipei/ should be 121.56705,25.03265 to point at the front entrance of the building rather than the back corner

http://www.mozilla.org/en-US/contact/spaces/san-francisco/ should be -122.38889,37.78955 to match the entrance to Mozilla's space (new first floor entrance, the old Gordon Biersch entrance)

http://www.mozilla.org/en-US/contact/spaces/london/ the building entrance is at -0.1271,51.5103

http://www.mozilla.org/en-US/contact/spaces/toronto/ the building entrance is at -79.39430,43.64715 (the marker is currently pointing at the wrong building)

http://www.mozilla.org/en-US/contact/spaces/tokyo/ looks perfect already.

http://www.mozilla.org/en-US/contact/spaces/mountain-view/ should be more like -122.08285,37.38795

I can't vouch for the locations of the others (though Vancouver and Auckland seem at least roughly correct, but OSM lacks building outlines; the other offices I haven't been to).

(If, on the other hand, the intent is to have the marker *cover* the office rather than to have the point the marker's pointer is pointing at be relevant, then I'd still suggest moving Paris and Toronto as I described, Taipei westwards but not northwards, and London southwards but not eastwards, and Mountain View westwards but not northwards.)

Comment 1

[Craig Cook (:craigcook)]

I believe all the pointer locations were just derived from the street addresses, so they tend to be along the street rather than pointing to a specific part of a building. We'll adjust them to be more precise, at least when the building entrance is known.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Craig Cook (:craigcook) from comment #1)
> so they tend to be along the street rather than pointing to a
> specific part of a building

That doesn't appear to be the case for many; my suggested revisions for both London, Taipei, and Toronto move the markers closer to the (addressed) street.

Comment 3

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/19f60b28b25fede9c034eff23517d6b07f373d48
[fix bug 944932] improve location of place markers on spaces pages

https://github.com/mozilla/bedrock/commit/69a3d2d941c34b81745ad49f834b97827de07524
Merge pull request #1524 from alexgibson/bug-944932-improve-location-of-place-markers-on-new-mozilla-spaces-pages

[fix bug 944932] improve location of place markers on spaces pages