Closed Bug 945023 Opened 6 years ago Closed 6 years ago
Texture and Create Texture For Offscreen out of GLContext
They should probably go into GLBlitHelper.*, since they are only used there and in SharedSurface* which #includes GLBlitHelper.h.
Move CreateTexture, CreateTextureForOffscreen, CreateRenderbuffer, and CreateRenderbuffersForOffscreen to GLBlitHelper.*
Attachment #8341536 - Flags: review?(bjacob)
Assignee: nobody → dglastonbury
Status: NEW → ASSIGNED
Comment on attachment 8341536 [details] [diff] [review] Move CreateTexture, et al out of GLContext. Review of attachment 8341536 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLBlitHelper.h @@ +18,5 @@ > > class GLContext; > > + > +// helper functions Please expand this comment a little bit to clarify that these helper functions are unrelated to GLBlitHelper; otherwise it might sounds as if they were helpers for GLBlitHelper.
Attachment #8341536 - Flags: review?(bjacob) → review+
Although, it's nice that GLBlitHelper::BlitFramebufferToFramebuffer actually uses one of these functions, so they're not 100% unrelated.
Updated helper function comments in response to review. Carry r+=bjacob.
Attachment #8342170 - Flags: review?(dglastonbury)
Attachment #8341536 - Attachment is obsolete: true
Attachment #8342170 - Flags: review?(dglastonbury) → review+
Dan: that means that either compilation, or some test, failed on some platform, and so Ryan had to back it out. The links Ryan gave in comment 7 should point you in the right direction.
Benoit: I understand. It looked like a compilation error. I pulled latest and don't have compile errors. Here's a push to try with my latest version of patch: https://tbpl.mozilla.org/?tree=Try&rev=8fb27ff9fe21
Fixed compile error on mozilla-inbound (Non-unified build) Carry r+=bjacob.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.