945023 - Move CreateTexture and CreateTextureForOffscreen out of GLContext

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

They should probably go into GLBlitHelper.*, since they are only used there and in SharedSurface* which #includes GLBlitHelper.h.

Comment 1

[u480271]

Attachment: Move CreateTexture, et al out of GLContext.

Move CreateTexture, CreateTextureForOffscreen, CreateRenderbuffer, and
CreateRenderbuffersForOffscreen to GLBlitHelper.*

Comment 2

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=6c6f93ee58bc

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8341536 [details] [diff] [review]
Move CreateTexture, et al out of GLContext.

Review of attachment 8341536 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLBlitHelper.h
@@ +18,5 @@
>  
>  class GLContext;
>  
> +
> +// helper functions

Please expand this comment a little bit to clarify that these helper functions are unrelated to GLBlitHelper; otherwise it might sounds as if they were helpers for GLBlitHelper.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Although, it's nice that GLBlitHelper::BlitFramebufferToFramebuffer actually uses one of these functions, so they're not 100% unrelated.

Comment 5

[u480271]

Attachment: Extract CreateTextureXXX and friends from GLContext.

Updated helper function comments in response to review. Carry r+=bjacob.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d673e562fa6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1d2c393849

https://tbpl.mozilla.org/php/getParsedLog.php?id=31463137&tree=Mozilla-Inbound

Comment 8

[u480271]

o_O?

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Dan: that means that either compilation, or some test, failed on some platform, and so Ryan had to back it out. The links Ryan gave in comment 7 should point you in the right direction.

Comment 10

[u480271]

Benoit: I understand. It looked like a compilation error. I pulled latest and don't have compile errors. Here's a push to try with my latest version of patch: https://tbpl.mozilla.org/?tree=Try&rev=8fb27ff9fe21

Comment 11

[u480271]

Attachment: Extract CreateTextureXXX and CreateRenderbufferXXX from GLContext

Fixed compile error on mozilla-inbound (Non-unified build)

Carry r+=bjacob.

Comment 12

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=a33591d786b0

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d405a9b2a8a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d405a9b2a8a