Closed Bug 945059 Opened 11 years ago Closed 11 years ago

Mark toolkit/profile and toolkit/components/startup as FAIL_ON_WARNINGS

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox28 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

part 1: toolkit/profile
540 bytes, patch
glandium
: review+
Details | Diff | Splinter Review
part 2: toolkit/components/startup
617 bytes, patch
glandium
: review+
Details | Diff | Splinter Review 
toolkit/profile and toolkit/startup are warning-free.

Let's annotate them.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=243d73c9a0d4
(In reply to Daniel Holbert [:dholbert] from comment #0)
> toolkit/profile and toolkit/startup are warning-free.

sorry, I meant toolkit/components/startup.
Summary: Mark toolkit/profile as FAIL_ON_WARNINGS → Mark toolkit/profile and toolkit/components/startup as FAIL_ON_WARNINGS

        Attachment #8340823 -
        Flags: review?(mh+mozilla)

    
    

    
  


  

        Attachment #8340825 -
        Flags: review?(mh+mozilla)

    
  
Depends on: FAIL_ON_WARNINGS

        Attachment #8340823 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
Comment on attachment 8340825 [details] [diff] [review]
part 2: toolkit/components/startup

Please fold the two patches when landing.

        Attachment #8340825 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
OK. Thanks for the reviews!

(I had them separated because I didn't realize that toolkit/profile & toolkit/components/startup were related, until I filed the bug. :))

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/105c2046f92c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

    
  

          status-firefox28:
          --- → fixed
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: