Mark toolkit/profile and toolkit/components/startup as FAIL_ON_WARNINGS

RESOLVED FIXED in Firefox 28

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla28
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox28 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
toolkit/profile and toolkit/startup are warning-free.

Let's annotate them.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=243d73c9a0d4
(Assignee)

Comment 1

5 years ago
(In reply to Daniel Holbert [:dholbert] from comment #0)
> toolkit/profile and toolkit/startup are warning-free.

sorry, I meant toolkit/components/startup.
Summary: Mark toolkit/profile as FAIL_ON_WARNINGS → Mark toolkit/profile and toolkit/components/startup as FAIL_ON_WARNINGS
(Assignee)

Comment 2

5 years ago
Created attachment 8340823 [details] [diff] [review]
part 1: toolkit/profile
Attachment #8340823 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
Created attachment 8340825 [details] [diff] [review]
part 2: toolkit/components/startup
Attachment #8340825 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Depends on: 557566
Attachment #8340823 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8340825 [details] [diff] [review]
part 2: toolkit/components/startup

Please fold the two patches when landing.
Attachment #8340825 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 5

5 years ago
OK. Thanks for the reviews!

(I had them separated because I didn't realize that toolkit/profile & toolkit/components/startup were related, until I filed the bug. :))
https://hg.mozilla.org/mozilla-central/rev/105c2046f92c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.