945098 - WVGA - 3:4 aspect ratio is hard coded into wallpaper selection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: Trying to select a screenshot (480x800) as my wallpaper, its forcing it to be cropped

When selecting a wallpaper from the Gallery, the app crops it to what I suspect is a 4:3 aspect ratio not the native aspect ratio of the device (5:3 in the case of the WVGA)

I also noticed the default wallpaper (green grass) on the WVGA device looks fuzzy when a new build is loaded. However when I select the same wallpaper from the wallpaper app, it gets a little sharper. So it might be up scaling the wallpaper at boot up.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

David or Dale, are we hard-coding the height/width in the code? Nothing showed up with quick |grep|.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This should probably block because it's a functionality issue.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

It is not hard coded in gallery app but in homescreen app[1].

[1] https://github.com/mozilla-b2g/gaia/blob/bece7cb20e790d0f562c45e2cb2b44b90e290ef6/apps/homescreen/js/wallpaper.js#L16-L17

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks, switching category.

We should update these values to window.screen.width and height times device pixel ratio. This is probably a good first bug. Please needinfo? me if you are interested taking this issue.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We would also need to change the numbers here

https://github.com/mozilla-b2g/gaia/blob/010b4de7d635ad59934693ffc3d05b7c4332b3c7/apps/settings/js/wallpaper.js#L44-L45

Comment 6

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 or 1.2?

Note - you'll likely need to use a Helix device to reproduce this.

Comment 7

[Matthew Vaughan]

This issue does reproduce on the Helix 12/03 1.1 and 1.2 builds. When attempting to set a 480X800 image as the wallpaper, the image will be cropped automatically.

Also, the issue of the default green grass wallpaper appearing a little fuzzy when launching a Firefox OS build for the first time does reproduce on the 12/03 1.2 build. It also reproduces on the 12/03 1.1 build with the default grayish reeds wallpaper. The image will become sharper once I set it as the wallpaper through the Display menu under Settings. 
NOTE: This issue can be reproduced by simply resetting the phone.

- Helix 1.1 Build -
Environmental Variables:
Device: Helix v1.1 COM RIL
BuildID: 20131203042203
Gaia: db9dd61b0a0e7ea9e3821dbae9775d90349578b0
Gecko: 155c632d4a41
Version: 18.0
Firmware Version: Y300-F1V100R001C00B004SP01
RIL Version: 01.01.00.019.281

- Helix 1.2 Build -
Environmental Variables:
Device: Helix v1.2 COM RIL
BuildID: 20131203004002
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Gecko: 244e98241b2c
Version: 26.0
Firmware Version: Y300-F1V100R001C00B004SP01
RIL Version: 01.02.00.019.102

Comment 8

[Jason Smith [:jsmith]]

Clarification - the 1.1 build is referring to 1.1 HD, not 1.1 directly. I double checked the commits - they reference the latest changes on 1.1 HD.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> This should probably block because it's a functionality issue.

If we're really going to consider blocking on this, then we should target the earliest release this reproduces on. Based on the testing above, it looks like this reproducing on 1.1 HD. Gregor has also confirmed reproduction on 1.1 HD.

Wayne - Can you triage this?

Comment 10

[Bruce Huang [:bhuang] (inactive)]

Triage: blocks for 1.1HD since as it is basic functionality

Comment 11

[Wayne Chang [:wchang]]

Tim,
Do you have someone to take this?

Thanks.

Comment 12

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#14354

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8342275 [details] [review]
mozilla-b2g:master PR#14354

Can anyone do a quick review here? Please remove other reviewers if you think your review is enough. :)

Comment 14

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8342275 [details] [review]
mozilla-b2g:master PR#14354

Looks good to me, 10x

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8342275 [details] [review]
mozilla-b2g:master PR#14354

r=me

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8342275 [details] [review]
mozilla-b2g:master PR#14354

Landing this patch since I got r+ from both homescreen and settings app peer.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/ac53e7aba6c8059cb6b01d72ac530ec25411539d
v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/4f44c617a8b0aea24bd93d41a7bdb2365538997e