945135 - [MediaEncoder] Refactor TrackEncoder and add VideoTrackEncoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Shelly Lin [:shelly]]

This is for landing Part 1 and Part 2 from bug 879669, for more details, please see bug 879669.

Carry r+ from roc.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=d38e4006114e

Comment 1

[Shelly Lin [:shelly]]

Attachment: Part1: Refactor of TrackEncoder

Carry r+ from bug 879669.

Comment 2

[Shelly Lin [:shelly]]

Attachment: Part2: Add VideoTrackEncoder

Comment 3

[Shelly Lin [:shelly]]

Comment on attachment 8340930 [details] [diff] [review]
Part2: Add VideoTrackEncoder

Review of attachment 8340930 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/VideoSegment.cpp
@@ +31,5 @@
>  VideoFrame::TakeFrom(VideoFrame* aFrame)
>  {
>    mImage = aFrame->mImage.forget();
>    mIntrinsicSize = aFrame->mIntrinsicSize;
> +  mForceBlack = aFrame->GetForceBlack();

Added the fix where |TakeFrom(aFrame)| should also copy the value of mForceBlack from aFrame.

Comment 4

[Shelly Lin [:shelly]]

Try result for the second part:
https://tbpl.mozilla.org/?tree=Try&rev=c7a5a0456da3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/72f2f506fe01
https://hg.mozilla.org/integration/b2g-inbound/rev/5dddd0b5ff51

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72f2f506fe01
https://hg.mozilla.org/mozilla-central/rev/5dddd0b5ff51