Closed Bug 945135 Opened 6 years ago Closed 6 years ago

[MediaEncoder] Refactor TrackEncoder and add VideoTrackEncoder

Categories

(Core :: Audio/Video: Recording, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: shelly, Assigned: shelly)

References

Details

(Whiteboard: [ft:media-recording][qa-])

Attachments

(2 files)

This is for landing Part 1 and Part 2 from bug 879669, for more details, please see bug 879669.

Carry r+ from roc.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=d38e4006114e
Carry r+ from bug 879669.
Attachment #8340925 - Flags: review+
Attachment #8340930 - Flags: review?(roc)
Comment on attachment 8340930 [details] [diff] [review]
Part2: Add VideoTrackEncoder

Review of attachment 8340930 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/VideoSegment.cpp
@@ +31,5 @@
>  VideoFrame::TakeFrom(VideoFrame* aFrame)
>  {
>    mImage = aFrame->mImage.forget();
>    mIntrinsicSize = aFrame->mIntrinsicSize;
> +  mForceBlack = aFrame->GetForceBlack();

Added the fix where |TakeFrom(aFrame)| should also copy the value of mForceBlack from aFrame.
Assignee: nobody → slin
Whiteboard: [ft:media-recording]
Try result for the second part:
https://tbpl.mozilla.org/?tree=Try&rev=c7a5a0456da3
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/72f2f506fe01
https://hg.mozilla.org/mozilla-central/rev/5dddd0b5ff51
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [ft:media-recording] → [ft:media-recording][qa-]
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.