Closed
Bug 945151
Opened 11 years ago
Closed 11 years ago
Mark toolkit/library as FAIL_ON_WARNINGS
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
555 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
toolkit/library is nearly warning-free. I think bug 945148 might be the final (& windows-only) warning there.
Filing this bug on labeling it as FAIL_ON_WARNINGS.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8340955 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Here's a nearly-all-green Try run with this patch:
https://tbpl.mozilla.org/?tree=Try&rev=28f7e07a30d7
(The windows reds are due to bug 945148)
And here's another (windows-only) Try run that also includes the current fix for bug 945148:
https://tbpl.mozilla.org/?tree=Try&rev=03dcc46a0636
|
||
Updated•11 years ago
|
Attachment #8340955 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•