Closed Bug 945151 Opened 6 years ago Closed 6 years ago

Mark toolkit/library as FAIL_ON_WARNINGS

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

toolkit/library is nearly warning-free. I think bug 945148 might be the final (& windows-only) warning there.

Filing this bug on labeling it as FAIL_ON_WARNINGS.
Attached patch fixSplinter Review
Attachment #8340955 - Flags: review?(benjamin)
Here's a nearly-all-green Try run with this patch:
  https://tbpl.mozilla.org/?tree=Try&rev=28f7e07a30d7
(The windows reds are due to bug 945148)

And here's another (windows-only) Try run that also includes the current fix for bug 945148:
  https://tbpl.mozilla.org/?tree=Try&rev=03dcc46a0636
Attachment #8340955 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/a6e99acbb26f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.