Closed Bug 945216 Opened 10 years ago Closed 10 years ago

Fix mozglue/ compilation on mingw.

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: jacek, Assigned: jacek)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch.diff
2.75 KB, patch
glandium
: review+
away
: feedback+
Details | Diff | Splinter Review
Attached patch patch.diff — — Splinter Review 
Bug 932100 caused a few problems:

- Linking version.lib should use EXPAND_LIBNAME, so that it's replaced by -lversion on mingw
- SEH blocks should use MOZ_SEH_* macros
- printf_stderr is declared as extern in nsDebug.h which conflicts with local static implementation. As a workaround, I made the mozglue variant non-static, which isn't perfect. I could also rename it or somehow share the implementation with xpcom glue as the comment suggests (what would be involved here?).
Attachment #8341030 - Flags: review?(dmajor)
Comment on attachment 8341030 [details] [diff] [review]
patch.diff

Review of attachment 8341030 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me but glandium knows the linking stuff better. Thanks for the patch!
Attachment #8341030 - Flags: review?(mh+mozilla)
Attachment #8341030 - Flags: review?(dmajor)
Attachment #8341030 - Flags: feedback+
Attachment #8341030 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0a33a6499fcc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.