Closed
Bug 945243
Opened 11 years ago
Closed 11 years ago
webgl-draw-buffers.html conformance test failures
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | affected |
firefox28 | --- | affected |
People
(Reporter: jrmuizel, Assigned: guillaume.abadie)
References
Details
(Whiteboard: webgl-driver)
Attachments
(1 file)
1.23 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
I see a couple of failures on my OS X 10.7 machine:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-draw-buffers.html
Reporter | ||
Comment 1•11 years ago
|
||
Guillaume, do you see these failures as well? If you do, do you have time to take a look at them?
Flags: needinfo?(guillaume.abadie)
Assignee | ||
Comment 2•11 years ago
|
||
Hi Jeff! =) I don't have any on Firefox 26, but I'm compiling the latest morzilla-central right now...
Flags: needinfo?(guillaume.abadie)
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Guillaume Abadie from comment #2)
> Hi Jeff! =) I don't have any on Firefox 26, but I'm compiling the latest
> morzilla-central right now...
Mozilla-Central* sorry :)
Assignee | ||
Comment 4•11 years ago
|
||
Oh... That is unfortunate... I'm having to many build error while trying to build on 10.9, and the campus' internet connection is to slow to download Firefox from the FTP right now (in fall 2013... -_-'). Will try tomorrow at the department!
Comment 5•11 years ago
|
||
FAIL getError expected: INVALID_ENUM. Was NO_ERROR : should not be able to attach pass the max attachment point: gl.COLOR_ATTACHMENT0 + 8
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #5)
> FAIL getError expected: INVALID_ENUM. Was NO_ERROR : should not be able to
> attach pass the max attachment point: gl.COLOR_ATTACHMENT0 + 8
BenWa gets this on 10.9
on 10.7 I also get:
--------- draw tests -----------
fragement shader
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
test that each texture got the correct color.
FAIL attachment 0 should be 255,0,0,0
at (24, 56) expected: 255,0,0,0 was 0,0,0,0
FAIL attachment 1 [details] [diff] [review] should be 0,255,0,0
at (2, 4) expected: 0,255,0,0 was 0,0,0,0
FAIL attachment 2 [details] [diff] [review] should be 255,255,0,0
at (4, 28) expected: 255,255,0,0 was 0,255,0,0
FAIL attachment 3 [details] [diff] [review] should be 0,0,255,0
at (12, 0) expected: 0,0,255,0 was 0,0,0,0
FAIL attachment 4 [details] [diff] [review] should be 255,0,255,0
at (28, 12) expected: 255,0,255,0 was 0,0,255,0
FAIL attachment 5 [details] should be 0,255,255,0
at (8, 20) expected: 0,255,255,0 was 0,0,0,0
FAIL attachment 6 [details] should be 255,255,255,0
at (10, 11) expected: 255,255,255,0 was 255,255,0,0
FAIL attachment 7 [details] should be 0,0,0,255
at (52, 2) expected: 0,0,0,255 was 0,0,0,0
Comment 7•11 years ago
|
||
Gross. We'll have to dig a little into this, but the 10.7 failures sound like we should just blocklist it.
The error on 10.9 is easy enough to work around.
Updated•11 years ago
|
Whiteboard: webgl-driver
Comment 8•11 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)
> (In reply to Benoit Girard (:BenWa) from comment #5)
> > FAIL getError expected: INVALID_ENUM. Was NO_ERROR : should not be able to
> > attach pass the max attachment point: gl.COLOR_ATTACHMENT0 + 8
>
> BenWa gets this on 10.9
>
... and on 10.8 with 'AMD Radeon HD 6750M 1024 MB' early 2011 MBP
Assignee | ||
Comment 9•11 years ago
|
||
Have found the bug :
http://dxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLFramebuffer.cpp#507
it is suppose to be a >= not >
Assignee | ||
Comment 10•11 years ago
|
||
Could I be assigned on this bug, and let me a little while for compiling firefox on 10.9 ? Thanks !
Assignee | ||
Comment 11•11 years ago
|
||
Here is the patch.
Push to try : https://tbpl.mozilla.org/?tree=Try&rev=7923b44458f4
Attachment #8342970 -
Flags: review?(jgilbert)
Comment 12•11 years ago
|
||
Comment on attachment 8342970 [details] [diff] [review]
patch revision 1
Review of attachment 8342970 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome. I love when the issue is so simple.
Attachment #8342970 -
Flags: review?(jgilbert) → review+
Comment 13•11 years ago
|
||
I believe this is what's affected.
status-firefox26:
--- → unaffected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #12)
> Comment on attachment 8342970 [details] [diff] [review]
> patch revision 1
>
> Review of attachment 8342970 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Awesome. I love when the issue is so simple.
My Pleasure! Surly my smallest patch ever! =)
https://hg.mozilla.org/integration/mozilla-inbound/rev/701c8c3fb409
We keep in touch for any other small regression like that I can do aside of my university projects! =)
Comment 15•11 years ago
|
||
Assignee: nobody → guillaume.abadie
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•