945341 - Kindle Fire: crash in android.content.ActivityNotFoundException: No Activity found to handle act=android.settings.SYNC_SETTINGS when opening Settings > Sync

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

This bug was filed from the Socorro interface and is 
report bp-07322fd0-4552-400d-8607-a310b2131128.
=============================================================

This is because Settings > Sync just fires an intent, and the Fire doesn't have the right components to handle it.

Solutions for this:

* Short term: hide that settings item on devices that can't handle it.
* Long term: build our own Sync settings UI, and don't call out to Android at all. (This will also fix a few other bugs.)

Comment 1

[Brian Carpenter [:geeknik]]

Just received this crash type in Firefox 26 on my Kindle Fire HDX 8.9:

https://crash-stats.mozilla.com/report/index/05f46ab4-8f1d-41df-ac84-d4b642140103

Not seeing this or the crash reporter every time I go into Settings->Sync though.

Comment 2

[Richard Newman [:rnewman]]

(In reply to Brian Carpenter [:geeknik] from comment #1)
 
> Not seeing this or the crash reporter every time I go into Settings->Sync
> though.

Could you clarify? Do you mean that *sometimes* you go into Settings > Sync, and something happens *other than* a crash?

Comment 3

[Brian Carpenter [:geeknik]]

Correct. Sometimes it appears as though nothing happens, but the browser is unresponsive for a few seconds like it restarted itself. But I don't see the crash reporter and there is no new entry in about:crashes. All of the tabs that were there before are still there (despite having Firefox set not to reopen tabs when you restart the browser).

Comment 4

[Marco Zehe (:MarcoZ)]

Is this still an issue with the new Firefox Sync UI in Firefox 29 +?

Comment 5

[Aaron Train [:aaronmt]]

Would be curious to know too, but alas I have no Kindle.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Crashes on 29 beta 1 and 2 have been reported.

Comment 7

[Aaron Train [:aaronmt]]

Well, on access to legacy Sync

Comment 8

[Richard Newman [:rnewman]]

It doesn't affect the new Sync UI, but will affect existing Sync 1.1 users.

Comment 9

[Richard Newman [:rnewman]]

For future reference: folks are installing the stock Android settings app on Kindles.

http://forum.xda-developers.com/showthread.php?t=1897380

Comment 10

[Richard Newman [:rnewman]]

Attachment: Don't fail to open Sync settings on Kindle

Behavior in modern Firefox -- that is, with FxA -- is pretty good already, and fine with this patch.

These changes, then, are for suckers like me -- we paired via old Sync, and now attempting to reach Settings will crash.

There's nothing much we can do about that, because there's no Settings app, but we can avoid the crash. Eventually we'll kill their old account and replace it with FxA, and the problem will go away.

Users who have installed a Settings app will be unaffected.

Chunks of this patch require upstreaming.

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8452584 [details] [diff] [review]
Don't fail to open Sync settings on Kindle

Review of attachment 8452584 [details] [diff] [review]:
-----------------------------------------------------------------

This one gets the gps "reluctant r+" treatment :)

Comment 12

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/5cc2818f40dd

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5cc2818f40dd

Comment 14

[Richard Newman [:rnewman]]

Comment on attachment 8452584 [details] [diff] [review]
Don't fail to open Sync settings on Kindle

Approval Request Comment
[Feature/regressing bug #]:
  Lack of Android functionality on Kindle Fire.

[User impact if declined]:
  Users with pre-FxA Sync accounts can reliably crash the browser by tapping "Sync" in Settings.

[Describe test coverage new/current, TBPL]:
  None. Manual testing only.

[Risks and why]: 
  Low risk: this is a band-aid. We're in the middle of a project to improve our experience on Kindle devices.

[String/UUID change made/needed]:
  None.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10b0cd0433a6