945360 - Fix three recently added hazards in spidermonkey

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: fix_new_hazards_in_sm-v0.diff

Pretty much trivial.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8341194 [details] [diff] [review]
fix_new_hazards_in_sm-v0.diff

Review of attachment 8341194 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Debugger.cpp
@@ +709,5 @@
>  
> +        if (obj->is<JSFunction>()) {
> +            RootedFunction fun(cx, &obj->as<JSFunction>());
> +            if (!EnsureFunctionHasScript(cx, fun))
> +                return false;

Is this the same one I just r+'ed for jonco too? You may get a conflict.

Comment 2

[Terrence Cole [:terrence]]

I thought that was me and I thought I had checked that in. Probably got dropped between tree closers with all the bustle at the hack week.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8b57cbe128a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8b57cbe128a