Closed Bug 945464 Opened 11 years ago Closed 11 years ago

Keep Scrolling Portion of Music App as One Layer using will-animate

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p=2 s= u=])

Attachments

(1 file, 1 obsolete file)

Github Pull Request
46 bytes, text/x-github-pull-request
dkuo
: review+
Details | Review 
Keep Scrolling Portion of Music App as One Layer using will-animate
Attached file Github pull request (obsolete) — 

        Attachment #8341356 -
        Flags: review?(bgirard)

        Attachment #8341356 -
        Flags: review?(bgirard)

    
    

    
  

      
      
      
      

        Attached file
          
        Github Pull Request
        — 
      

    


  
We wanted to get a music peer to review this patch. Did we add will-animate: scroll to the right CSS place?

Thanks!

        Attachment #8341356 -
        Attachment is obsolete: true

        Attachment #8345636 -
        Flags: review?(dkuo)

    
    

    
  
Comment on attachment 8345636 [details] [review]
Github Pull Request

Mason,

Thanks for working on this, I have checked the will-animate css you added, you got the right places so this patch looks good to me! Also I saw the other apps already landed the new will-animate css property, and since your patch failed on the Travis CI, I am going to cherry-pick your patch and run the Travis CI again, after that goes green I will land it for you.

        Attachment #8345636 -
        Flags: review?(dkuo) → review+

    
    

    
  
Landed on master: 0985280ffc917353eb34ff7b0dcc1c152856450c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Awesome thanks for landing and reviewing.
Depends on: will-change

    
  
Target Milestone: 1.2 C6(Dec6) → 1.3 C1/1.4 S1(20dec)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: