Keep Scrolling Portion of Music App as One Layer using will-animate

RESOLVED FIXED in 1.3 C1/1.4 S1(20dec)

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

({perf})

unspecified
1.3 C1/1.4 S1(20dec)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c=handeye p=2 s= u=])

Attachments

(1 attachment, 1 obsolete attachment)

Keep Scrolling Portion of Music App as One Layer using will-animate
(Assignee)

Comment 1

5 years ago
Created attachment 8341356 [details] [review]
Github pull request
Attachment #8341356 - Flags: review?(bgirard)
Attachment #8341356 - Flags: review?(bgirard)
(Assignee)

Comment 2

5 years ago
Created attachment 8345636 [details] [review]
Github Pull Request

We wanted to get a music peer to review this patch. Did we add will-animate: scroll to the right CSS place?

Thanks!
Attachment #8341356 - Attachment is obsolete: true
Attachment #8345636 - Flags: review?(dkuo)
Comment on attachment 8345636 [details] [review]
Github Pull Request

Mason,

Thanks for working on this, I have checked the will-animate css you added, you got the right places so this patch looks good to me! Also I saw the other apps already landed the new will-animate css property, and since your patch failed on the Travis CI, I am going to cherry-pick your patch and run the Travis CI again, after that goes green I will land it for you.
Attachment #8345636 - Flags: review?(dkuo) → review+
Landed on master: 0985280ffc917353eb34ff7b0dcc1c152856450c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Awesome thanks for landing and reviewing.
Depends on: 961871

Updated

5 years ago
Target Milestone: 1.2 C6(Dec6) → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.