945509 - Bug 114365 broke non-unified builds

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Mike Hommey [:glandium]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=31337684&tree=Birch

In file included from ../../../../content/base/src/FragmentOrElement.cpp:17:
In file included from ../../../dist/include/mozilla/dom/FragmentOrElement.h:19:
../../../dist/include/nsIContent.h:249:15: error: inline function 'nsIContent::IsInHTMLDocument' is not defined [-Werror,-Wundefined-inline]
  inline bool IsInHTMLDocument() const;
              ^
../../../../content/base/src/FragmentOrElement.cpp:2540:7: note: used here
  if (IsInHTMLDocument()) {
      ^
1 error generated.

Comment 1

[(no longer active)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=31341803&tree=Birch

Comment 2

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> https://tbpl.mozilla.org/php/getParsedLog.php?id=31341803&tree=Birch

That's the right log, thanks.

Pasting the error:
                from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/mozilla/RefPtr.h: In instantiation of 'static T* mozilla::RefPtr<T>::ref(T*) [with T = mozilla::gfx::GlyphRenderingOptions]':
../../dist/include/mozilla/RefPtr.h:222:47:   required from 'mozilla::TemporaryRef<T>::TemporaryRef(T*) [with T = mozilla::gfx::GlyphRenderingOptions]'
../../dist/include/gfxFont.h:1497:43:   required from here
../../dist/include/mozilla/RefPtr.h:197:9: error: invalid use of incomplete type 'class mozilla::gfx::GlyphRenderingOptions'
In file included from ../../../layout/generic/nsTextRunTransformations.h:11:0,
                 from ../../../layout/generic/MathVariantTextRunFactory.h:9,
                 from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/gfxFont.h:63:7: error: forward declaration of 'class mozilla::gfx::GlyphRenderingOptions'
In file included from ../../dist/include/gfxPlatform.h:20:0,
                 from ../../dist/include/gfxFontUtils.h:9,
                 from ../../dist/include/gfxFont.h:12,
                 from ../../../layout/generic/nsTextRunTransformations.h:11,
                 from ../../../layout/generic/MathVariantTextRunFactory.h:9,
                 from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/mozilla/RefPtr.h: In instantiation of 'static void mozilla::RefPtr<T>::unref(T*) [with T = mozilla::gfx::GlyphRenderingOptions]':
../../dist/include/mozilla/RefPtr.h:228:23:   required from 'mozilla::TemporaryRef<T>::~TemporaryRef() [with T = mozilla::gfx::GlyphRenderingOptions]'
../../dist/include/gfxFont.h:1497:43:   required from here
../../dist/include/mozilla/RefPtr.h:203:9: error: invalid use of incomplete type 'class mozilla::gfx::GlyphRenderingOptions'
In file included from ../../../layout/generic/nsTextRunTransformations.h:11:0,
                 from ../../../layout/generic/MathVariantTextRunFactory.h:9,
                 from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/gfxFont.h:63:7: error: forward declaration of 'class mozilla::gfx::GlyphRenderingOptions'
In file included from ../../dist/include/gfxPlatform.h:20:0,
                 from ../../dist/include/gfxFontUtils.h:9,
                 from ../../dist/include/gfxFont.h:12,
                 from ../../../layout/generic/nsTextRunTransformations.h:11,
                 from ../../../layout/generic/MathVariantTextRunFactory.h:9,
                 from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/mozilla/RefPtr.h: In instantiation of 'static void mozilla::RefPtr<T>::unref(T*) [with T = mozilla::gfx::ScaledFont]':
../../dist/include/mozilla/RefPtr.h:228:23:   required from 'mozilla::TemporaryRef<T>::~TemporaryRef() [with T = mozilla::gfx::ScaledFont]'
../../dist/include/gfxFont.h:1747:76:   required from here
../../dist/include/mozilla/RefPtr.h:203:9: error: invalid use of incomplete type 'class mozilla::gfx::ScaledFont'
In file included from ../../dist/include/gfxFontUtils.h:9:0,
                 from ../../dist/include/gfxFont.h:12,
                 from ../../../layout/generic/nsTextRunTransformations.h:11,
                 from ../../../layout/generic/MathVariantTextRunFactory.h:9,
                 from ../../../layout/generic/MathVariantTextRunFactory.cpp:6:
../../dist/include/gfxPlatform.h:51:7: error: forward declaration of 'class mozilla::gfx::ScaledFont'

Comment 3

[(no longer active)]

Attachment: Include 2D.h in gfxFont.h because it uses ScaledFont; r=glandium

Comment 4

[(no longer active)]

Benoit, any chance you could please work on getting rid of this include?  I think I worked pretty hard a while ago to take it out, so it's sad that I have to add it back again. :(

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7e96ff87420

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7e96ff87420

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> Benoit, any chance you could please work on getting rid of this include?  I
> think I worked pretty hard a while ago to take it out, so it's sad that I
> have to add it back again. :(

I agree that it continues to be worth minimizing #include "2D.h" where we can; I can't commit to anything but knowing that you care about it ups the likeliness that I'd look at it soon.

If you want to go further and put into question the idea of a single big 2D.h header for moz2d, you need to talk with moz2d people, especially Bas Schouten.