Closed
Bug 945564
Opened 12 years ago
Closed 12 years ago
Move DataAlignment static const to function scope for unified build.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: shu, Assigned: shu)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.68 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Building in unified mode might cause the DataAlignment static consts to
conflict when we add/remove new sources to JS.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8341442 -
Flags: review?(jdemooij)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8341442 [details] [diff] [review]
Move DataAlignment static const to function scope for unified build.
Review of attachment 8341442 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/BaselineJIT.cpp
@@ +362,5 @@
> size_t pcMappingIndexEntries, size_t pcMappingSize,
> size_t bytecodeTypeMapEntries)
> {
> + // Be safe, align IC entry list to 8 in all cases.
> + static const unsigned DataAlignment = sizeof(uintptr_t);
Pre-existing nit, but this comment is bogus for x86/ARM (4-byte pointers). We should probably just remove it.
Attachment #8341442 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•