If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move DataAlignment static const to function scope for unified build.

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Building in unified mode might cause the DataAlignment static consts to
conflict when we add/remove new sources to JS.
(Assignee)

Comment 1

4 years ago
Created attachment 8341442 [details] [diff] [review]
Move DataAlignment static const to function scope for unified build.
Attachment #8341442 - Flags: review?(jdemooij)
Comment on attachment 8341442 [details] [diff] [review]
Move DataAlignment static const to function scope for unified build.

Review of attachment 8341442 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/BaselineJIT.cpp
@@ +362,5 @@
>                      size_t pcMappingIndexEntries, size_t pcMappingSize,
>                      size_t bytecodeTypeMapEntries)
>  {
> +    // Be safe, align IC entry list to 8 in all cases.
> +    static const unsigned DataAlignment = sizeof(uintptr_t);

Pre-existing nit, but this comment is bogus for x86/ARM (4-byte pointers). We should probably just remove it.
Attachment #8341442 - Flags: review?(jdemooij) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c743a0cd2e2
https://hg.mozilla.org/mozilla-central/rev/5c743a0cd2e2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.