Closed Bug 945568 Opened 6 years ago Closed 6 years ago

Crash [@ ensureLinear] due to OOM in ReadFile

Categories

(Core :: JavaScript Engine, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 2 open bugs)

Details

(Keywords: crash, testcase, Whiteboard: [jsbugmon:update])

Attachments

(1 file)

The following test crashes on mozilla-central revision e014d47fc576 (no options required):

oomAfterAllocations(1);
read("x");


The problem is caused by calling ResolvePath and not checking its return value properly. Patch attached.
Attachment #8341455 - Flags: review?(terrence)
Comment on attachment 8341455 [details] [diff] [review]
js-readfile-oom.patch

Review of attachment 8341455 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me
Attachment #8341455 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/bb06cc9a7088
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.