945591 - Extension with the SDK's toolbarbutton module no longer displays toolbar button

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

When I enable the add-on, I see this logged:

"[CustomizableUI]" "Widget 'transmission-button' not found, unable to move" CustomizableUI.jsm:142

The code for this button is here:

https://github.com/canuckistani/transmission-magnet-helper/blob/master/lib/main.js#L182-L189

Until today, this worked.

Comment 1

[:Gijs (he/him)]

(In reply to Jeff Griffiths (:canuckistani) from comment #1)
> Until today, this worked.

How literally "today"? The SDK uplift was not too long ago, and contained several fixes for the widget library. It's possible they impacted this library as well. Otherwise we'd have to look elsewhere, but I didn't think we landed much that would have impacted this the last 24 hours... Proper regression window would help!

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to :Gijs Kruitbosch from comment #1)
> (In reply to Jeff Griffiths (:canuckistani) from comment #1)
> > Until today, this worked.
> 
> How literally "today"? The SDK uplift was not too long ago, and contained
> several fixes for the widget library. It's possible they impacted this
> library as well. Otherwise we'd have to look elsewhere, but I didn't think
> we landed much that would have impacted this the last 24 hours... Proper
> regression window would help!

Literally just yesterday, as today it works again.

I only saw this using nightly with a specific extension, I'm going to spend a little time with some simple test extensions using this library and see if anything crops up. If I can't repro, I'll close it.

Comment 3

[:Gijs (he/him)]

(In reply to Jeff Griffiths (:canuckistani) from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > (In reply to Jeff Griffiths (:canuckistani) from comment #1)
> > > Until today, this worked.
> > 
> > How literally "today"? The SDK uplift was not too long ago, and contained
> > several fixes for the widget library. It's possible they impacted this
> > library as well. Otherwise we'd have to look elsewhere, but I didn't think
> > we landed much that would have impacted this the last 24 hours... Proper
> > regression window would help!
> 
> Literally just yesterday, as today it works again.

Weeeeeeiiiird. :-(

> I only saw this using nightly with a specific extension, I'm going to spend
> a little time with some simple test extensions using this library and see if
> anything crops up. If I can't repro, I'll close it.

Did you have another chance to look at this?

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to :Gijs Kruitbosch from comment #3)
> Did you have another chance to look at this?

I have not been able to repro, and I am running two different add-ons that use the toolbarbutton module ( my own, and cheevos ).