945627 - Remove FIXUP_FLAG_USE_UTF8

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 393246 obsoleted FIXUP_FLAG_USE_UTF8.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Remove the tracking of UTF-8ness

Comment 2

[Henri Sivonen (:hsivonen)]

https://tbpl.mozilla.org/?tree=Try&rev=87544e7b4908

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8341597 [details] [diff] [review]
Remove the tracking of UTF-8ness

>--- a/browser/base/content/utilityOverlay.js
>+++ b/browser/base/content/utilityOverlay.js

>   // Currently, this parameter works only for where=="tab" or "current"
>-  var aIsUTF8               = params.isUTF8;

stray comment

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8341597 [details] [diff] [review]
Remove the tracking of UTF-8ness

Review of attachment 8341597 [details] [diff] [review]:
-----------------------------------------------------------------

::: docshell/base/nsIURIFixup.idl
@@ +11,5 @@
>  
>  /**
>   * Interface implemented by objects capable of fixing up strings into URIs
>   */
> +[scriptable, uuid(3820bb0a-39fc-4ee0-a2bb-f5b9a0e48fc2)]

The iid bump is not needed. It will not change the vtable layout to remove a constant from the interface.

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Address previous comments

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8342988 [details] [diff] [review]
Address previous comments

Can you add a note in the idl, at the end of the flag list, pointing out that an earlier flag value is available?

r=me

Comment 7

[Henri Sivonen (:hsivonen)]

Thanks for the reviews.

(In reply to Boris Zbarsky [:bz] from comment #6)
> Can you add a note in the idl, at the end of the flag list, pointing out
> that an earlier flag value is available?

Landed with such a note added to both .idl files:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e15bc7f7e4c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e15bc7f7e4c

Comment 9

[[e-mail]]

(I wonder how I was supposed to notice the removal of this flag? Nothing would have stopped working, because the flag no longer existed so the code that attempted to set the flag did nothing but trigger a strict warning, which would have required a debug build to notice, which I have stopped using because they are too slow. Possibly I might have noticed if the checkin comment mentioned FIXUP_FLAG_USE_UTF8.)

Comment 10

[Dão Gottwald [:dao]]

(In reply to [e-mail] from comment #9)
> (I wonder how I was supposed to notice the removal of this flag? Nothing
> would have stopped working, because the flag no longer existed so the code
> that attempted to set the flag did nothing but trigger a strict warning,
> which would have required a debug build to notice, which I have stopped
> using because they are too slow.

You can set javascript.options.strict = true in optimized builds.