Closed Bug 945627 Opened 7 years ago Closed 7 years ago

Remove FIXUP_FLAG_USE_UTF8

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Bug 393246 obsoleted FIXUP_FLAG_USE_UTF8.
Attached patch Remove the tracking of UTF-8ness (obsolete) — Splinter Review
Depends on: 393246
Comment on attachment 8341597 [details] [diff] [review]
Remove the tracking of UTF-8ness

>--- a/browser/base/content/utilityOverlay.js
>+++ b/browser/base/content/utilityOverlay.js

>   // Currently, this parameter works only for where=="tab" or "current"
>-  var aIsUTF8               = params.isUTF8;

stray comment
Comment on attachment 8341597 [details] [diff] [review]
Remove the tracking of UTF-8ness

Review of attachment 8341597 [details] [diff] [review]:
-----------------------------------------------------------------

::: docshell/base/nsIURIFixup.idl
@@ +11,5 @@
>  
>  /**
>   * Interface implemented by objects capable of fixing up strings into URIs
>   */
> +[scriptable, uuid(3820bb0a-39fc-4ee0-a2bb-f5b9a0e48fc2)]

The iid bump is not needed. It will not change the vtable layout to remove a constant from the interface.
Attachment #8341597 - Attachment is obsolete: true
Attachment #8342988 - Flags: review?(bzbarsky)
Attachment #8342988 - Flags: review?(dao)
Attachment #8342988 - Flags: review?(dao) → review+
Comment on attachment 8342988 [details] [diff] [review]
Address previous comments

Can you add a note in the idl, at the end of the flag list, pointing out that an earlier flag value is available?

r=me
Attachment #8342988 - Flags: review?(bzbarsky) → review+
Thanks for the reviews.

(In reply to Boris Zbarsky [:bz] from comment #6)
> Can you add a note in the idl, at the end of the flag list, pointing out
> that an earlier flag value is available?

Landed with such a note added to both .idl files:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e15bc7f7e4c
https://hg.mozilla.org/mozilla-central/rev/7e15bc7f7e4c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
(I wonder how I was supposed to notice the removal of this flag? Nothing would have stopped working, because the flag no longer existed so the code that attempted to set the flag did nothing but trigger a strict warning, which would have required a debug build to notice, which I have stopped using because they are too slow. Possibly I might have noticed if the checkin comment mentioned FIXUP_FLAG_USE_UTF8.)
(In reply to neil@parkwaycc.co.uk from comment #9)
> (I wonder how I was supposed to notice the removal of this flag? Nothing
> would have stopped working, because the flag no longer existed so the code
> that attempted to set the flag did nothing but trigger a strict warning,
> which would have required a debug build to notice, which I have stopped
> using because they are too slow.

You can set javascript.options.strict = true in optimized builds.
You need to log in before you can comment on or make changes to this bug.