945733 - Cannot change regions after the "Packaged apps are not yet supported for those platforms." message is displayed

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Victor Carciu]

Prerequisites:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0

Steps to reproduce:
1.Go to MP Stage and submit a new PACKAGED app
2.Select the submitted app and go to "Compatibility & Payments" section 
3.Check the "Firefox Mobile" and "Firefox Tablet" checkboxes and click the "Save Changes" button. Observe the  "Packaged apps are not yet supported for those platforms." message 
4.From "Regions" , select\deselect some countries and press "Save Changes"

Expected results:
The "Packaged apps are not yet supported for those platforms." message is not displayed anymore and changes are saved to Regions

Actual results:
The message is still displayed and changes made to Regions are not saved

Please see screencast for this bug : http://screencast.com/t/JtezviUa

Comment 1

[Stuart Colville [:muffinresearch]]

Note: this also happens in prod with Free apps.

Comment 2

[Stuart Colville [:muffinresearch]]

I've been looking into this to try and debug it. 

This bug is caused by some weirdness in that the hidden multi-select #id_free_platforms (in the case of a free app) is showing selected values following a post to add devices that aren't allowed with a packaged app. Even though the data used to build the links (with checkboxes is fine - the checkbox selected is un-checked).

This then also means the JS sees that the select is out of sync with the checkboxes and so you have to click twice to "really" un-check the device - as the JS is updating the select behind the scenes.

The select having incorrect initial data is why the error message persists when it shouldn't. I'm trying to find where in device form or the payments form this occurs.

@cvan if you know and more feel free to add some details here.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

We have two flags: `android-packaged` and `desktop-packaged`. Just a few minutes ago I enabled them on stage:

    https://marketplace.allizom.org/admin/models/waffle/flag/

Those waffle flags have to be enabled in order to mark a packaged app as supported for Android or Desktop:

    http://f.cl.ly/items/3B3l0e1r37062q363G41/Screen%20Shot%202013-12-05%20at%2012.53.53%20PM.png

If an app is packaged and the `android-packaged`/`desktop-packaged` waffle flags are disabled, we should *not* be showing the platforms (nor their checkboxes) at all. That seems like a regression but maybe it never was.

To summarize: when the waffle flags are enabled, everything seems to be working fine and as expected. When the waffle flags are disabled, we should be hiding the unavailable platforms for packaged apps.

Comment 4

[Stuart Colville [:muffinresearch]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> We have two flags: `android-packaged` and `desktop-packaged`. Just a few
> minutes ago I enabled them on stage:
> 
>     https://marketplace.allizom.org/admin/models/waffle/flag/
> 
> Those waffle flags have to be enabled in order to mark a packaged app as
> supported for Android or Desktop:
> 
>    
> http://f.cl.ly/items/3B3l0e1r37062q363G41/Screen%20Shot%202013-12-
> 05%20at%2012.53.53%20PM.png
> 
> If an app is packaged and the `android-packaged`/`desktop-packaged` waffle
> flags are disabled, we should *not* be showing the platforms (nor their
> checkboxes) at all. That seems like a regression but maybe it never was.

It's not a regression this has always been like this - this bug existed prior to recent changes around the device checkboxes wrt to android-payments and it exists for free as well as paid too.

> 
> To summarize: when the waffle flags are enabled, everything seems to be
> working fine and as expected. When the waffle flags are disabled, we should
> be hiding the unavailable platforms for packaged apps.

Gotcha - I will make it so.

Comment 5

[Stuart Colville [:muffinresearch]]

PR: https://github.com/mozilla/zamboni/pull/1501

Comment 6

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/0ea9a681b0bea9cfafaa5bc0336f9a67a7208c87

** I'll add a comment when stage is updated. **

QA Notes:

Here's a few suggestions of what to look for. This will need to be checked on both -dev and stage in order to check both states of the android-payments, android-packaged, desktop-packaged states. 

Note: these changes only affect the Compatibility and payments page and not the initial submission.

* Check submission of both packaged and standard apps.
* Check conversion of free to paid and vice versa.
* Check device selections in "Compatibility and Payments" work as expected (and based on the waffle flags)

If android-payments is on:

* You should be able to select android mobile/tablet as paid apps for non-packaged.

If android-payment and android-packaged is on:

* You should be able to select android mobile/tablet as paid apps for both packaged and non-packaged.

If desktop-packaged is on:

* You should be able to select desktop-packaged for free apps (but not for paid).

The tab for paid should flag the incorrect device selection if you are attempting to change to paid and an invalid device type is currently selected.

Comment 7

[Stuart Colville [:muffinresearch]]

Ok this is on stage.

Here are the current flag settings (as at the time of writing this comment)

Staging:
 
* android-payments - on 
* android-packaged - on 
* desktop-packaged - on

Dev

* android-payments - off 
* android-packaged - on
* desktop-packaged - off

Comment 8

[Victor Carciu]

Verified as fixed.