Closed
Bug 945773
Opened 12 years ago
Closed 12 years ago
[Settings] 1.3 Visual Refresh - Add NFC Icon
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amylee, Assigned: pivanov)
References
Details
(Whiteboard: visual design, visual-tracking, jian)
Attachments
(4 files)
settings_mock.gif
Hi Pavel,
I the NFC header is using the wrong icon (airplane). I've added the NFC icon to the sprite sheets. Can you please update?
Thanks!
|
Reporter | |
Updated•12 years ago
|
Assignee: amylee.design → pivanov
|
|
Reporter | |
Comment 1•12 years ago
|
||
Hi Pavel,
Here is a mock of the settings screen with where the icon needs to be replaced. The right side shows the correct icon used for NFC.
Thanks!
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8341902 -
Flags: feedback?(amylee.design)
|
|
Reporter | |
Comment 3•12 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 8341902 [details]
> After patch screenshot
This looks good. Thanks Pavel!
|
|
Reporter | |
Updated•12 years ago
|
Attachment #8341902 -
Flags: feedback?(amylee.design) → feedback+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #8341922 -
Flags: review?(epang)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8341922 [details] [review]
patch for Gaia/master
Thanks Pavel, looks good! We can land it :)
Attachment #8341922 -
Flags: review?(epang) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/2adbf9c9c19b59dfa40d8871e22f32765cc34c39
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Blocks: 1.3-visual-refresh
You need to log in
before you can comment on or make changes to this bug.
Description
•