945813 - Paper over cycle collection problem in IndexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Andy Wingo [:wingo]]

Bug 943409 describes an instance of a cycle collection problem in indexedDB, and adds a minimal test case.  There are three instances of this problem in the codebase:

  dom/indexedDB/test/unit/test_cursor_mutation.js
  dom/indexedDB/test/unit/test_index_object_cursors.js
  dom/indexedDB/test/unit/test_index_update_delete.js

The attached patch works around the issues in these three tests, in preparation for bug 927782.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Paper over cycle collection problem in IndexedDB

Comment 2

[Andy Wingo [:wingo]]

Comment on attachment 8341801 [details] [diff] [review]
Paper over cycle collection problem in IndexedDB

Adding mccr8 for a quick review; it's the same as bug 943409, but with two additional tests.  Adding khuey as suggested there for rubber stampage.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2572592c326d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Whoops, meant to back this one out the first time for the xpcshell crashes but accidentally did bug 945828 instead. Please make sure this passes on Try before requesting checkin again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb35692e00ec

Comment 5

[Andy Wingo [:wingo]]

Yep, sorry about that.  Odd that it passes locally...

Comment 6

[Andy Wingo [:wingo]]

Attachment: Paper over cycle collection problem in IndexedDB

Comment 7

[Andy Wingo [:wingo]]

Attachment: Paper over cycle collection problem in IndexedDB khuey

Comment 8

[Andy Wingo [:wingo]]

Comment on attachment 8342347 [details] [diff] [review]
Paper over cycle collection problem in IndexedDB   khuey

New patch uses eval('') to force all locals onto the scope chain, to better simulate what will happen after bug 927782 lands.  Instead of relying on gc, manually null out locals that cause cycles.  Tested locally on linux64-debug; trybuild here: https://tbpl.mozilla.org/?tree=Try&rev=a76ba05fd069

Marking r+ as it is pretty much the same as previous patches.

Comment 9

[Andy Wingo [:wingo]]

Looking green, https://tbpl.mozilla.org/?tree=Try&rev=fc1f986c5aac -- let's hit it

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/815cd189ae2c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/815cd189ae2c