Closed
Bug 945844
Opened 11 years ago
Closed 11 years ago
GenerationalGC: Fix a couple of problems in browser builds
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.85 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Here's a patch to fix a couple of minor issues in GGC browser builds: 1. Builds complain that HashKeyRef in jsweakmap.cpp is unknown. It needs a namespace prefix, but I don't know why this works in shell builds. Oh wait, it's probably the unified source thing. 2. StoreBuffer::enabled is not initialised. Again this works for shell builds but blows up for browser builds.
Attachment #8341848 -
Flags: review?(sphink)
|
||
Updated•11 years ago
|
Attachment #8341848 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d791c9be9a6e
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d791c9be9a6e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•