946005 - Make Valgrind builds work on try

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Nicholas Nethercote [inactive]]

For Valgrind builds to be unhidden, they need to be selectable via trychooser.
(They also need to be runnable on Try, which is bug 801955.)

Comment 1

[Nicholas Nethercote [inactive]]

> For Valgrind builds to be unhidden, they need to be selectable via
> trychooser.
> (They also need to be runnable on Try, which is bug 801955.)

Bug 801955 didn't end up enabling them on try, so that's now part of this bug.

Comment 2

[Chris AtLee [:catlee]]

The problem actually is try chooser here. The builders exist in buildbot, but try chooser doesn't let you choose them, so it's impossible to actually get a valgrind build.

Comment 3

[Chris AtLee [:catlee]]

Attachment: valgrind-buildbotcustom-2.diff

maybe this will just work?

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8346608 [details] [diff] [review]
valgrind-buildbotcustom-2.diff

Review of attachment 8346608 [details] [diff] [review]:
-----------------------------------------------------------------

And it does indeed appear to just work:

% clearpending
Cleared 2076 pending builds
% showpending 
% C=a1c636ee4706; buildbot sendchange --master localhost:9900 -u [e-mail] -b try -r $C -l "http://hg.mozilla.org/try/rev/$C" -c 'biscuit try: -b do -p linux64-valgrind -u none' -P hazards js/src/squeezebot.cpp 
change sent successfully
% showpending
Linux x86-64 try valgrind
%

\o/

Nice!

Comment 5

[Nicholas Nethercote [inactive]]

Another gold star for catlee :)  Thanks!

Comment 6

[[e-mail] (:bhearsum)]

In production

Comment 7

[Nicholas Nethercote [inactive]]

I'm seeing Valgrind jobs occurring in |-p all| jobs, and also in a |try: -b o -p linux64-valgrind -u none -t none| test I just pushed (https://tbpl.mozilla.org/?tree=Try&rev=95b9ffbf9231&jobname=valgrind&showall=1).  Great!

Now we just need to update trychooser.  Let's do that in another bug.  I filed bug 950223.