946018 - [B2G] [Facebook] Played videos are half shown in landscape mode

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect, P2)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of Facebook video (Portrait)

Description:
Videos played from Facebook on the device have the bottom half cut off when viewed in landscape mode.

Repro Steps:
1) Update Buri to Build ID: 20131126004001
2) Launch Facebook from either the Social section of Everything.me or by downloading the app in the Marketplace.
3) Login with a valid username and password.
4) Navigate to a video clip on the current user or a friend's page and play it.
5) Observe the appearance of the video in both portrait and landscape orientations.

Actual:
The video appears normal in portrait mode, but in landscape mode the video pane is shown with the bottom half cut off.

Expected:
The video appears normal in both portrait and landscape orientations.

Environmental Variables
Device: Buri 1.2 commercial RIL
Build ID: 20131126004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/21e2ad082d85
Gaia: 264c6044b941437ac3c4b28fe4ca392d2bc78445
Platform Version: 26.0
RIL Version: 01.02.00.019.102

Does not repro on Leo 1.1 mozilla RIL
Build ID: 20131118041241
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/7c3cfc0936ca
Gaia: b585b32441fafa67f2b4582db23be5f3a2afab21
Platform Version: 18.1

Notes:
Assisted by Ross Kuhlman
Repro frequency: 100%
See attached screenshots

Comment 1

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of Facebook video (Landscape)

Comment 2

[Preeti Raghunath(:Preeti)]

Sotaro,

Please help move this forward.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #2)
> Sotaro,
> 
> Please help move this forward.

Adding blocking+ per triage - facebook needs to be solid, as it's a partner app.

Comment 4

[Matthew Vaughan]

It appears that this issue has been occurring since the first 1.2 build from 6/21. From 6/21 to 7/01, the video would be cut off in both landscape and portrait. From 7/02 and on, the issue described in comment 0 occurs; the video is only cut off in landscape.

- Broken (as described in comment 0) -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130702031336
Gaia: d463818bd666fe53e10e828a842b7f48693ccd7b
Gecko: 4ffb23062b3b
Version: 25.0a1
Firmware Version: v1.2_20131115

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

hi Marco, someone on your team can look into this? thanks

Comment 6

[Marco Chen [:mchen]]

Blake will have a investigation first.

Comment 7

[Jason Smith [:jsmith]]

Elisa - this isn't a TE issue. It's a gecko bug.

Comment 8

[Colby Rabideau]

Jason is correct: as of this week, we serve video files to Firefox clients in a bare browser window.

Comment 9

[Kai-Chih Hu [:khu]]

Because 1.2 is going to be finished, should we mark this bug from koi+ to 1.3+? Thanks.

Comment 11

[Jason Smith [:jsmith]]

Well, apparently the dupe shows this reproducing on 1.1 HD, which makes this really, really bad. We need to block on this & get this fixed asap.

Wayne - Can you triage & bump the priority here? This is a blocker for a partner app.

Comment 12

[Wayne Chang [:wchang]]

This happens on the launched Leo v1.1 software as well, could it be something to do with what's mentioned in comment 8?

Comment 13

[Jason Smith [:jsmith]]

(In reply to Wayne Chang [:wchang] from comment #12)
> This happens on the launched Leo v1.1 software as well, could it be
> something to do with what's mentioned in comment 8?

Wait, really? The testing in comment 0 originally indicated this didn't reproduce on 1.1. Can someone double check this? Does this reproduce on 1.1?

Comment 14

[Sotaro Ikeda [:sotaro]]

Confirmed the symptom on my device. It seems that a pop up window's height is not updated correctly. I am going to investigate more.

Comment 15

[Sarah Parsons]

I can repro this issue on Buri 1.1 Build ID: 20131213041208

Gaia   6ff3a607f873320d00cb036fa76117f6fadd010f
SourceStamp bdac595a4e46
BuildID 20131213041208
Version 18.0

Comment 16

[Jason Smith [:jsmith]]

Sounds like that confirms the problem is caused by a facebook app change. We should fix this via outreach.

If we want to look into the gecko bug separately here, then let's open a new bug to investigate the gecko bug here.

Comment 17

[Nicole Fong]

Jason, what's the status?

Comment 18

[Nicole Fong]

Bug reproduced on Peak v1.3

Do we have any updates?

Comment 19

[Colby Rabideau]

As I said before, we changed the behavior of our site to let the browser/os display videos in a bare browser window. There is no Facebook JS, CSS or HTML in that window. Just a video file.

The problem is with the way the browser handles video files.

Comment 20

[Jason Smith [:jsmith]]

(In reply to Colby Rabideau from comment #19)
> As I said before, we changed the behavior of our site to let the browser/os
> display videos in a bare browser window. There is no Facebook JS, CSS or
> HTML in that window. Just a video file.
> 
> The problem is with the way the browser handles video files.

Then you need to revert the change. This is breaking Facebook on all shipping devices right now.

Comment 21

[:Harald Kirschner :digitarald]

Just to recap: Currently there is no FB UI involved in the playback. On 1.0 to 1.3 this cuts off the video, which seems to be a bug in the OS. Before the recent update, FB provided a wrapper to play back the video. Is that correct?

jsmith: is there a bug logged on why videos are played back cut off if this is present in 1.3?

colby: As we can't fix the issue on shipping devices, would it be possible to get back the old behavior for FxOS?

Comment 22

[Colby Rabideau]

@Harald yes and no.

We do have an inline player that supports some browsers. Before January as the result of a bug, some  Firefox mobile users (FxOS & Android) received (broken) inline videos when viewing a user's timeline. We received a couple bugzilla reports about the problem which prompted some refactoring to sure up our browser checks on inline videos.

I can't really revert because theres nothing working to revert to :(

I'm looking into supporting Firefox with the inline player. The problem I've had there is that the similator's video player seems to be different from the one that runs on device, and we can't get FxOS devices on our internal network so for the most part I'm flying blind.

Is Firefox for Android's video handling roughly equivalent to FxOS? That would make testing a whole lot easier.

Comment 23

[:Harald Kirschner :digitarald]

If you already have FxOS detection code in there you could trigger Web Activities for viewing videos which will open the native Video player app.

I don't think this happens on Firefox for Android, but can't tell as I couldn't find videos in my feed. Youtube works fine.

Comment 24

[Colby Rabideau]

Alright, thanks Harald. I'll check it out.

Comment 25

[Jason Smith [:jsmith]]

Don't think so - can you file a separate bug for this?

Comment 26

[Nicole Fong]

Seems to be fixed on my Buri v1.3.  Harald- can you verify this so we can close this bug out, please?  Thanks.

Comment 27

[:Harald Kirschner :digitarald]

Videos were scaled correctly on Nexus 4 with 1.5.

Video playback in general is not great as videos open in chromeless mode without much UI. I wonder if thats more of a platform bug and how the OS handles opening a video.

Comment 28

[:Harald Kirschner :digitarald]

Links now open in a new window which opens the browser. Please re-test.