Closed Bug 946025 Opened 7 years ago Closed 7 years ago
[B2G][Settings][Internet Sharing] Enabling Wi-fi hotspot without a SIM card inserted does not prompt user
Description: Enabling Wi-fi hotspot withou ta sim card inserted does not prompt the user that the action is invalid. The user could therefore attempt to Wi-fi Hotspot while being blocked from doing so, and not know. Repro Steps: 1) Updated Buri to Build ID: 20131126004001 2) Insure no sim card is present and wifi is disabled. 3) Navigate to settings, and then to Internet sharing. 4) Enable Wi-Fi hotspot and observe devices behaviour Actual: Wi-fi hotspot does not give indication that it is inopperable whilst wifi and sim card are missing. Expected: Wi-fi hotspot gives proper indication that it is not usable, without sim card and wifi. (Stays inactive) Environmental Variables Device: Buri v 1.2.0 COM RIL Build ID: 20131126004001 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/21e2ad082d85 Gaia: 264c6044b941437ac3c4b28fe4ca392d2bc78445 Platform Version: 26.0 RIL Version: 01.02.00.019.102 Notes: Repro frequency: 3/3
Occurs in Buri v 1.1.0
I would like take this issue. Please assign it to me.
I made simple patches of two kinds 1. Attachment : Bug946025_disableInternetSharingWithNoSimcard.patch – This is same situation of call settings, message settings and Cellular & data. If device doesn't have SIM Card, Internet sharing menu is disabled and show "No SIM Card" token 2. Attachment : Bug946025_NoSimcardInHotspot.patch – If turning on hotspot when device doesn't have SIM Card, ModalDialog is showed and turn off hotspot. Because I don't know specific scenario, I make two patches. Can you inform specific scenario?
If I'm reading it right, the first one would block the ability to have a user utilize their WiFi connection and share it with another device via USB tethering when they don't have a SIM card. The specific scenario is that a user that lacks a SIM card tries to create a WiFi hotspot won't be able to since they require using the WiFi to receive internet and can't use the WiFi to also broadcast simultaneously. In that case I believe the second patch is better.
I upload patch. Please review
Hello Leo - unfortunately Alive is likely away on holiday for the next week, so expect some delay in code review.
(In reply to Dietrich Ayala (:dietrich) from comment #8) > Hello Leo - unfortunately Alive is likely away on holiday for the next week, > so expect some delay in code review. Actually, he apparently decided to skip his own holiday to come to Systems FE work week. So he's actually working.
Comment on attachment 8369306 [details] Pull request URL #15899 Drive by: I think we need to work on this copy here a bit. I'm flagging Stephany for feedback, but feel free to forward this to a more appropriate party.
Attachment #8369306 - Flags: feedback?(swilkes)
Comment on attachment 8369306 [details] Pull request URL #15899 Basically r+, but could we have UX confirm on this behavior?
Comment on attachment 8369306 [details] Pull request URL #15899 Flagging Juwei on UX review of the patch(es). Juwei, if the UX is 100% great with you, please ui-review+. If it is not ready to ship and you have suggestions for changes, please ui-review- and comment here with changes that should be made. Thanks!
Attachment #8369306 - Flags: feedback?(swilkes) → feedback?(jhuang)
Comment on attachment 8369306 [details] Pull request URL #15899 Re-flag to Omega, who is UX owner of Settings now. Hi Omega, could you help to review this patch?
Attachment #8369306 - Flags: ui-review?(jhuang) → ui-review?(ofeng)
Comment on attachment 8369306 [details] Pull request URL #15899 This patch doesn't disable Internet sharing nor prompt no-sim message.
Attachment #8369306 - Flags: ui-review?(ofeng) → ui-review-
Comment on attachment 8369306 [details] Pull request URL #15899 My device's SIM module has some problems in the comment #14. After double-checking the patch with another device, found this patch is ui-review+.
Attachment #8369306 - Flags: ui-review- → ui-review+
Dear Alive kuo Can you lend this patch to git?
The patch breaks some internet-sharing unit test https://travis-ci.org/mozilla-b2g/gaia/builds/18630496 Someone needs to fix it otherwise we can't land.
Dear, I fix internet-sharing unit test. But, the patch can't pass unit test now.(AppInstallManager, LockScreenConnInfoManager and ManifestHelper) https://travis-ci.org/mozilla-b2g/gaia/builds/19552968 Can you give me some guides?
I change travis-ci URL(NotificationScreen unit test error) https://travis-ci.org/mozilla-b2g/gaia/builds/19554547
Thanks for your help! Can you land this patch to git?
master https://github.com/mozilla-b2g/gaia/commit/ace6e432ad9bed8b6c4b7b363e17cd5db1f6c5ed Thanks for contributing!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.