Closed Bug 946030 Opened 11 years ago Closed 11 years ago

HTMLTextAreaElement should be considered an input element for text selection

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

Product:
Firefox for Android Graveyard
Component:
Text Selection
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox28 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox28 --- verified

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(1 file, 1 obsolete file)

bug946030
2.95 KB, patch
wesj
: review+
Margaret
: feedback+
Details | Diff | Splinter Review
Attached patch bugta (obsolete) — — Splinter Review 
Tapping into text in a focused <textarea> should present a textselection handle/caret

Also, the selection should be shareable, and searchable
Attachment #8342066 - Flags: review?(margaret.leibovic)
Attached patch bug946030 — — Splinter Review 
This is probably more correct, noticing ... http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#5132
Assignee: nobody → markcapella
Attachment #8342066 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8342066 - Flags: review?(margaret.leibovic)
Attachment #8342085 - Flags: review?(margaret.leibovic)
Comment on attachment 8342085 [details] [diff] [review]
bug946030

This seems reasonable to me, but I'm passing the review over to wesj, since he has more context here around the getFocusedInput check.
Attachment #8342085 - Flags: review?(wjohnston)
Attachment #8342085 - Flags: review?(margaret.leibovic)
Attachment #8342085 - Flags: feedback+
Attachment #8342085 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/7bda9296f32b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Status: RESOLVED → VERIFIED
status-firefox28: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: