946048 - Check against uninitialized value in BluetoothHFPManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Valgrind error:

==370== Conditional jump or move depends on uninitialised value(s)
==370==    at 0x5D5444A: mozilla::dom::bluetooth::BluetoothHfpManager::ResetCallArray() (BluetoothHfpManager.cpp:345)
==370==    by 0x5D54593: mozilla::dom::bluetooth::BluetoothHfpManager::Reset() (BluetoothHfpManager.cpp:360)
==370==    by 0x5D54951: mozilla::dom::bluetooth::BluetoothHfpManager::BluetoothHfpManager() (BluetoothHfpManager.cpp:333)
==370==    by 0x5D549AF: mozilla::dom::bluetooth::BluetoothHfpManager::Get() (BluetoothHfpManager.cpp:473)
==370==    by 0x5D5A12D: mozilla::dom::bluetooth::BluetoothServiceBluedroid::BluetoothServiceBluedroid() (BluetoothServiceBluedroid.cpp:752)
==370==    by 0x5D4A84B: mozilla::dom::bluetooth::BluetoothService::Create() (BluetoothService.cpp:321)
==370==    by 0x5D4B27F: mozilla::dom::bluetooth::BluetoothService::Get() (BluetoothService.cpp:760)
==370==    by 0x5C5AFA3: BluetoothServiceConstructor(nsISupports*, nsID const&, void**) (BluetoothService.h:112)
==370==    by 0x55F04E7: mozilla::GenericFactory::CreateInstance(nsISupports*, nsID const&, void**) (GenericFactory.cpp:16)
==370==    by 0x562EB5B: nsComponentManagerImpl::CreateInstanceByContractID(char const*, nsISupports*, nsID const&, void**) (nsComponentManager.cpp:1084)
==370==    by 0x562ED71: nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) (nsComponentManager.cpp:1440)
==370==    by 0x55F1D6D: nsGetServiceByContractID::operator()(nsID const&, void**) const (nsComponentManagerUtils.cpp:252)

It's a check against mPhoneType in BluetoothHFPManager::ResetCallArray. Will need to be fixed in both bluedroid (which is what the stack refers to) and bluez implementations.

Comment 1

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Reset mPhoneType in HFP manager constructor, r=echou

The patch resets mPhoneType for both bluez and bluedroid.

Comment 2

[Ben Tian (inactive)]

try server: https://tbpl.mozilla.org/?tree=Try&rev=04fa6a1bc78a

Comment 3

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/001297dd060a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/001297dd060a