Closed Bug 946116 Opened 6 years ago Closed 6 years ago

security/manager/ssl/src/nsNSSCallbacks.cpp: [-Wunused-variable] unused variable 'isResumedSession'

Categories

(Core :: Security: PSM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Bug 942729 stopped passing isResumedSession to SetHandshakeCompleted(), but forgot to remove the now unused variable isResumedSession.
Attachment #8342213 - Flags: review?(brian)
Comment on attachment 8342213 [details] [diff] [review]
remove-isResumedSession-variable.patch

Review of attachment 8342213 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this. Looks like we need to turn on WARNINGS_AS_ERRORS for non-Windows and Windows builds in PSM.
Attachment #8342213 - Flags: review?(brian) → review+
Severity: normal → trivial
Component: Security → Security: PSM
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/77116d856962
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.