946189 - Can no longer build under windows with --disable-crashreporter ('mCrashReporterMutex' : undeclared identifier)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Bill Gianopoulos [:WG9s]]

Windows builds specifying --disable-crashreproter fail here:

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginModuleParent.cpp#1564

with undeclared identifier mCrashReporterMutex.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Fix Windows build issue

Comment 2

[Bill Gianopoulos [:WG9s]]

Oops I thought I had requested review from bsmedberg.   My Bad!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/638131799dd7

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/638131799dd7

Comment 5

[Ronny Perinke]

the patch is also needed for firefox27

Comment 6

[Bill Gianopoulos [:WG9s]]

The patch that caused the regression has also landed on Aurora.  I am not sure if that means this should be as well.  It is a trivial, obvious fix, but it only impacts doing local windows builds with non-standard build options.

Comment 7

[Benjamin Kerensa [:bkerensa]]

No need to track although if a low risk uplift would help go ahead and nominate it.

Comment 8

[Bill Gianopoulos [:WG9s]]

Issue here is.  Do we really care?  Exactly who would be building Firefox 27 with a non-standard mozconfig who would also not have the capability to apply the patch themselves?