946200 - Use the new texture client/host with Linux OMTC by default instead of the deprecated textures.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

New textures work better on Linux than their deprecated counterpart. I didn't make them default because close to nobody was using OMTC-Linux but with main-thread GL layers being gone, it's become a different story.
In case this isn't clear, I am not talking about using OMTC by default. Just using the new textures rather than the deprecated ones when OMTC is used.

Comment 1

[Nicolas Silva [:nical]]

Attachment: new textrues with Linux OMTC + async-video

Bonus: also use async-video on Linux. async-video is the default for fennec and b2g and is one of the few reasons OMTC is useful at all on desktop (especially as long as we don't has APZC on desktop). It works well on Linux so let's use it.

Comment 2

[Nicolas Silva [:nical]]

try push: https://tbpl.mozilla.org/?tree=Try&rev=44bd1c63ecd0

Comment 3

[Nick Cameron [:nrc]]

Comment on attachment 8342348 [details] [diff] [review]
new textrues with Linux OMTC + async-video

Review of attachment 8342348 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!

::: modules/libpref/src/init/all.js
@@ +4255,5 @@
>  // requires off-main-thread compositing.
>  pref("layers.async-video.enabled",false);
>  
> +#ifdef MOZ_X11
> +// OMTC off by default on Linux, but if activated, use new textures and async-video.

OMTC is kind of on for Linux if HWA is on, at least on nightly. It's just not reflected in the prefs. So, this comment is kind of confusing, I would just remove it.

Comment 4

[Nicolas Silva [:nical]]

try servers had infrastructure issues during the last push so here's another one https://tbpl.mozilla.org/?tree=Try&rev=aa443984f585

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

FWIW, I flipped the layers.use-deprecated-textures pref locally (to avoid bug 945632), and I'm seeing a bunch of black flashing, I think whenever things with native theme drawing get layerized, or something like that.  Not sure if that's a known issue.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

... and also random black boxes over PDFs rendered by PDF.js, such as https://wiki.mozilla.org/images/e/e0/SF%2C_1.pdf

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Nical, where is this bug in this picture: https://wiki.mozilla.org/Platform/GFX/textures#Planned_work ?

Comment 8

[Nicolas Silva [:nical]]

(In reply to Milan Sreckovic [:milan] from comment #7)
> Nical, where is this bug in this picture:
> https://wiki.mozilla.org/Platform/GFX/textures#Planned_work ?

That would have to be added I guess. This diagram focuses on goals about the "supported OMTC" platforms. Even though Linux is not prioritized for OMTC yet, I'd rather have people use the new textures than the deprecated if they flip the pref, because there are known problems with the deprecated textures, and also because, as we are about to remove deprecated textures code, it just won't work soon.

I can add it to the diagram if you think having people using new textures when they opt in to OMTC on linux is something that should be considered as a dependency of something else. In that case I suppose flipping the pref on Linux would appear as a dependency of "(VI) new textures is the default everywhere"

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #5)
> FWIW, I flipped the layers.use-deprecated-textures pref locally (to avoid
> bug 945632), and I'm seeing a bunch of black flashing, I think whenever
> things with native theme drawing get layerized, or something like that.  Not
> sure if that's a known issue.

David, which platform?

Comment 10

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/615eb1c448df

Comment 11

[Nicolas Silva [:nical]]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #5)
> FWIW, I flipped the layers.use-deprecated-textures pref locally (to avoid
> bug 945632), and I'm seeing a bunch of black flashing, I think whenever
> things with native theme drawing get layerized, or something like that.  Not
> sure if that's a known issue.

Sorry about the very late reply, this was a component alpha bug with the new ContentClient that is fixed now.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/615eb1c448df