946240 - [Bluetooth][gonk-kk] [bluedroid]Porting bluetooth module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Bluetooth module is complied failed in gonk-kk.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I'm working on this.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

A few build errors:
BluetoothDeviceEventBinding.cpp:156:16: error: invalid use of incomplete type 'class mozilla::dom::BluetoothDeviceEvent'
../../dist/include/mozilla/dom/BluetoothDeviceEventBinding.h:17:7: error: forward declaration of 'class mozilla::dom::BluetoothDeviceEvent'

BluetoothDiscoveryStateChangedEventBinding.cpp:166:16: error: invalid use of incomplete type 'class mozilla::dom::BluetoothDiscoveryStateChangedEvent'

../../dist/include/mozilla/dom/BluetoothStatusChangedEventBinding.h:15:7: error: forward declaration of 'class mozilla::dom::BluetoothStatusChangedEvent'
They are all webidl related.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

It looks like js/xpconnect/src/event_impl_gen.conf.in, MOZ_B2G_BT was not defined.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Build errors in AVRCP HAL, we need to add one callback in the front of callback btrc_remote_features_callback.
Since AVRCP HAL API changed in kitkat.

../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)()' to 'btrc_remote_features_callback {aka void (*)(bt_bdaddr_t*, btrc_remote_features_t)}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(btrc_player_attr_t)' to 'btrc_list_player_app_attr_callback {aka void (*)()}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(uint8_t, btrc_player_attr_t*) {aka void (*)(unsigned char, btrc_player_attr_t*)}' to 'btrc_list_player_app_values_callback {aka void (*)(btrc_player_attr_t)}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(uint8_t, uint8_t, uint8_t*) {aka void (*)(unsigned char, unsigned char, unsigned char*)}' to 'btrc_get_player_app_attrs_text_callback {aka void (*)(unsigned char, btrc_player_attr_t*)}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(btrc_player_settings_t*)' to 'btrc_get_player_app_values_text_callback {aka void (*)(unsigned char, unsigned char, unsigned char*)}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(uint8_t, btrc_media_attr_t*) {aka void (*)(unsigned char, btrc_media_attr_t*)}' to 'btrc_set_player_app_value_callback {aka void (*)(btrc_player_settings_t*)}' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothA2dpManager.cpp:391:1: error: invalid conversion from 'void (*)(btrc_event_id_t, uint32_t) {aka void (*)(btrc_event_id_t, unsigned int)}' to 'btrc_get_element_attr_callback {aka void (*)(unsigned char, btrc_media_attr_t*)}' [-fpermissive]

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: avrcp-kitkat.patch

btrc_remote_features_callback was added in KitKat, which is the first callback function of btrc_callbacks_t. We need to add it, otherwise, signature of callback functions will not be matched.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shuang] [:shawnjohnjr] from comment #3)
> It looks like js/xpconnect/src/event_impl_gen.conf.in, MOZ_B2G_BT was not
> defined.
This was caused by changing configure.in after code generated. auto-gen files shall need to re-generate again.
After that, things are good.
So I think we only need attachment 8350594 [details] [diff] [review].

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

HFP/A2DP looks good on KitKat.

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

KitKat bluetooth HAL now added AVRCP 1.4 feature for AbsoluteVolume in HAL. We shall open another bug. For this bug, we just focus on functions that 1.3 version supported.

Comment 9

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8350594 [details] [diff] [review]
avrcp-kitkat.patch

Review of attachment 8350594 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. This also reminds me that maybe we could use the same flag to exclude AVRCP 1.3 related code if Android 4.2.2 or previous version is used. Make sense?

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 946240 - [Bluetooth][gonk-kk]Add flag to support different AVRCP profile version

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shuang] [:shawnjohnjr] from comment #10)
> Created attachment 8351165 [details] [diff] [review]
> Bug 946240 - [Bluetooth][gonk-kk]Add flag to support different AVRCP profile
> version
This change would support JB 4.2.x, since JB 4.2 does not support AVRCP 1.3, based on Comment 9, in this patch, which fixes build break in JB 4.2. We have to do it since there are still a few BSPs only support Android 4.2.

Comment 12

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8351165 [details] [diff] [review]
Bug 946240 - [Bluetooth][gonk-kk]Add flag to support different AVRCP profile version

Review of attachment 8351165 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please make sure it compiles in all cases(ANDROID_VERSION < 17, = 17 and > 17). Thanks.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Compiled on Android JB 4.3, Android JB 4.2 with bluedroid.

Comment 15

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 946240 - [Bluetooth][gonk-kk]Add flag to support different AVRCP profile version, r=echou

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://tbpl.mozilla.org/?tree=Try&rev=df4ae76054d1

Comment 17

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I also tried to build on different versions 4.2.2, 4.3, 4.4.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/065cf8a72645

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/065cf8a72645