946254 - display device firmware version in b2g datazilla

Status: RESOLVED FIXED

(Datazilla Graveyard :: User interface, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In order to detect when new firmware causes a change in results it would be very useful to include the firmware in the result display.  The version can be acquired using adb like this:

  adb shell cat /system/build.prop | grep incremental | cut -f 2 -d =

Which will give a result like:

  eng.archermind.20131114.105818

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Is there anything else that we might want to add at the same time? Looking at build.prop, perhaps the following would be useful in identifying the build in use?

ro.build.id
ro.build.version.incremental
ro.build.version.release
ro.build.date.utc

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I think the date element would be useful to know when it was built.  (Not sure I understand the date.utc element...)

I guess the release would tell us what vintage of android kernel we are building on.

I think the id field may have information we don't want to show.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Pointer to Github pull request: https://github.com/mozilla/b2gperf/pull/28

Pointer to Github pull-request

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8345882 [details]
Pointer to Github pull request: https://github.com/mozilla/b2gperf/pull/28

This is the first part, which will submit this data to DataZilla in the 'test_build' key. The final part will be updating the DataZilla UI to show this new data.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8345882 [details]
Pointer to Github pull request: https://github.com/mozilla/b2gperf/pull/28

Looks good to me.

Comment 6

[Jonathan Eads ( :jeads )]

So it looks like ro.build.version.incremental, ro.build.version.release, and ro.build.date.utc were added to ancillary data. Do you want those properties displayed in the "Test Replicates" panel when a data point is selected? Are the new keys that will appear in the 'test_build' structure in the JSON ro.build.version.incremental, ro.build.version.release, and ro.build.date.utc? Are there any other new attributes I should display in 'test_build'?

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Jonathan Eads ( :jeads ) from comment #6)
> So it looks like ro.build.version.incremental, ro.build.version.release, and
> ro.build.date.utc were added to ancillary data. Do you want those properties
> displayed in the "Test Replicates" panel when a data point is selected?

Yes, I think that was the idea. If we could convert the unix timestamp in ro.build.date.utc to a human readable format that would be great.

> Are the new keys that will appear in the 'test_build' structure in the JSON
> ro.build.version.incremental, ro.build.version.release, and
> ro.build.date.utc?

Yes, but let's label them differently in the UI. I would suggest 'Firmware version (incremental)', 'Firmware version (release)', and 'Firmware date'.

> Are there any other new attributes I should display in 'test_build'?

No, but we should probably hold off on these changes until I've released a new version of b2gperf and started submitting the data, just to be sure.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Okay, here's an example of the new data being sent to datazilla:

{"json_blob": {"test_machine": {"platform": "Gonk", "osversion": "1.2.0.0-prerelease", "os": "Firefox OS", "name": "e4:2d:02:1b:e8:ac", "type": "hamachi"}, "testrun": {"date": 1386898824, "suite": "video"}, "results": {"fps_hwc": [58.176500000000004, 17.098400000000002, 16.744199999999999, 17.27815, 54.3979, 17.316499999999998, 17.314550000000001, 16.425049999999999, 56.427300000000002, 56.231699999999996, 16.633499999999998, 52.256100000000004, 57.02225, 16.508500000000002, 60.1355, 17.109200000000001, 58.480649999999997, 50.785049999999998, 59.097300000000004, 56.993200000000002, 56.557299999999998, 53.415100000000002, 56.1252, 18.443899999999999, 17.275300000000001, 54.988100000000003, 55.351399999999998, 17.920300000000001, 56.149000000000001, 36.220700000000001], "fps": [58.960524300103621, 59.120793770316631, 59.363389493616815, 59.00617790998011, 59.255880484751927, 59.105781522924026, 59.237991734510196, 59.127954244487256, 59.31262227030016, 59.156497002124624, 59.351649403354379, 59.280866798707081, 59.271025045678194, 59.092585098311858, 59.251125334602079, 59.150796530393698, 59.309237742444516, 59.175912335276436, 59.289595364839784, 59.304001218787505, 59.225171145283085, 59.156968544220248, 59.267495721558809, 59.192060963479634, 59.222617326908612, 59.217035322361198, 59.369085875167173, 59.17368404153703, 59.363504811903908, 58.966266842411905]}, "test_build": {"ro.build.date.utc": "1384397913", "ro.build.version.release": "4.0.4", "name": "B2G", "restart": true, "delay": 5.0, "version": "prerelease", "gecko_revision": "860c939d1860eec4cb40f92d4a3c722e52445fee", "branch": "v1.2", "gaia_revision": "1aca7c4860e39b1a9969807d335dcf9f070ea9b3", "settle_time": 60, "revision": "1aca7c4860e39b1a9969807d335dcf9f070ea9b3", "id": "20131212004004", "build_revision": "59605a7c026ff06cc1613af3938579b1dddc6cfe", "ro.build.version.incremental": "eng.archermind.20131114.105818"}}, "date_loaded": 1386898791, "error_flag": "N", "test_run_id": 88658, "processed_flag": "complete", "error_msg": ""}

https://datazilla.mozilla.org/b2g/refdata/objectstore/json_blob/88660