946320 - [Australis] history widget missing a "Tabs From Other Devices" entry

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

There seems to be no way to reach the "Tabs from other devices" view in Australis, short of pressing alt and invoking the old-school menus.

Comment 1

[Matthew N. [:MattN]]

Yeah, it seems like it's missing from the history widget.

Marking as P3 since this existed in the Firefox menu prior to Australis.

Comment 2

[Matthew N. [:MattN]]

Attachment: Screenshot in the Firefox menu on Win. 7

Comment 3

[Justin Dolske [:Dolske]]

Preemptively bumping to P2 because Sync is a big-deal again.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[:Gijs (he/him)]

Comment on attachment 8355381 [details] [diff] [review]
Patch

Review of attachment 8355381 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me. We could theoretically also use the Weave object from a window if we were checking things, but then we'd have to pass windows around so this is probably easier. The other thing I noticed is that we don't have a separator after "Clear Recent History" and the history menu does, but that was an issue before this bug...

(could do with a test but I don't know how hard that is... are there tests for the original history menu?)

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to :Gijs Kruitbosch from comment #5)
> The other thing I noticed is that we don't have
> a separator after "Clear Recent History" and the history menu does, but that
> was an issue before this bug...

That can get fixed in bug 928843.
 
> (could do with a test but I don't know how hard that is... are there tests
> for the original history menu?)

None that I could find, but I wrote one for this.

Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/7eeec6c0e1c6

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Landed a follow-up to fix orange on fx-team, https://hg.mozilla.org/integration/fx-team/rev/561a743626c1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7eeec6c0e1c6
https://hg.mozilla.org/mozilla-central/rev/561a743626c1