946335 - about:start no longer displays scrollbars

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Jim Mathies [:jimm]]

This regressed in bug 902505. Commenting out updateViewport code fixes it.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

We were setting an incorrect CSS viewport for the start page, because we shrink the browser on about:start to account for the navbar.

While testing this I also noticed that we set "about:home" as an alias for "about:start" in AboutRedirector.js, but weren't treating it like the start page in BrowserUI.  This patch also fixes that.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8344131 [details] [diff] [review]
patch

There seems to be a timing issue with this patch; it doesn't set the correct viewport when switching from a non-about:start page to an about:start page, probably because the padding hasn't been adjusted yet.  Working on a fix.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

This adds code to update the viewport after we resize the browser when the start page loads or unloads.

Comment 4

[Marco Mucci [:MarcoM]]

Hey Matt, can you provide a point value.

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to Marco Mucci [:MarcoM] from comment #4)
> Hey Matt, can you provide a point value.

p=1

Comment 6

[Marina Samuel [:emtwo]]

Comment on attachment 8344199 [details] [diff] [review]
patch v2

Review of attachment 8344199 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good to me. Though for some reason, I do see the scrollbar with a pull from this morning without the patch. Not sure if it's perhaps the screen resolution affecting it or something else? But ok if it works for you.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e20f6d0c911

Comment 8

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8344199 [details] [diff] [review]
patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 902505

User impact if declined: Can't scroll Metro start page with mouse.

Testing completed (on m-c, etc.): Baked on m-c since 12/9.

Risk to taking this patch (and alternatives if risky): Low-risk Metro-only patch.

String or IDL/UUID changes made by this patch: None.

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e51e3611210a

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Verified using latest nightly and latest aurora builds on Windows 8.1 (32bit and 64bit). 
The scrollbars are now shown on about:start.