Closed
Bug 946351
Opened 11 years ago
Closed 11 years ago
Misissued Google certificates from DCSSI
Categories
(NSS :: CA Certificates Code, task, P1)
NSS
CA Certificates Code
Tracking
(blocking-b2g:koi+, firefox25 wontfix, firefox26+ verified, firefox27+ verified, firefox28+ verified, firefox-esr17 wontfix, firefox-esr2426+ verified, b2g18 affected, b2g-v1.1hd affected, b2g-v1.2 fixed)
People
(Reporter: curtisk, Assigned: briansmith)
Details
(Keywords: csectype-other, sec-high, Whiteboard: [adv-main26+][adv-esr24.2+])
Attachments
(5 files, 1 obsolete file)
2.03 KB,
patch
|
wtc
:
review+
briansmith
:
checked-in+
|
Details | Diff | Splinter Review |
2.35 KB,
patch
|
KaiE
:
review+
rrelyea
:
review+
wtc
:
review+
briansmith
:
checked-in+
|
Details | Diff | Splinter Review |
961 bytes,
patch
|
wtc
:
review+
KaiE
:
checked-in+
|
Details | Diff | Splinter Review |
mozilla-beta: Update to NSS 3.15.3.1 and fix the root module version number [beta26 already covered]
5.97 KB,
patch
|
Details | Diff | Splinter Review | |
7.53 KB,
text/plain
|
Details |
![]() |
Reporter | |
Comment 2•11 years ago
|
||
![]() |
Reporter | |
Updated•11 years ago
|
Keywords: csectype-other,
sec-critical
Comment 4•11 years ago
|
||
Moving to NSS component so we can add release-blocking flags
Assignee: kwilson → brian
Group: crypto-core-security
Flags: needinfo?(brian)
Product: mozilla.org → NSS
Version: other → 3.15.3
![]() |
Reporter | |
Comment 5•11 years ago
|
||
There are 2 questions that come to mind for me
1) Do we chemspill a 25.0.2 given the site and timeframe for public disclosure? Also Chrome has already patched
2) What is the window for respin on 26.0 final?
Comment 6•11 years ago
|
||
(In reply to Curtis Koenig [:curtisk] from comment #5)
> There are 2 questions that come to mind for me
> 1) Do we chemspill a 25.0.2 given the site and timeframe for public
> disclosure? Also Chrome has already patched
> 2) What is the window for respin on 26.0 final?
Chempsilling a 25.0.2 will take a significant amount of resources and might put the 26.0 release at risk, if we can do anything to hold this until Tuesday Dec 10th for the 26.0 release we might be able to avoid the need for a 25.0.2
A respin of 26.0 could definitely start today, be with QA Thurs/Fri and ready for shipping on Tuesday.
Updated•11 years ago
|
status-firefox25:
--- → affected
status-firefox26:
--- → affected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
tracking-firefox25:
--- → +
tracking-firefox26:
--- → +
tracking-firefox27:
--- → +
tracking-firefox28:
--- → +
Comment 7•11 years ago
|
||
We need to get this blocked in next week's releases (all of them). Given the proximity of the release a chemspill is probably overkill and too disruptive. AIUI this does mean we have to respin what we thought were our final Fx26 and ESR24.2 builds
Comment 8•11 years ago
|
||
More info from Google:
At the moment, my best guess is that this is another TURKTRUST like
event: where a MITM proxy has been installed with full, public
authority. That's a major breach of the CA's process, to be sure, but
it's not a major attack against users. We don't have evidence of a
widespread attack, although it is odd that the certificate was
observed outside of France.
Assignee | ||
Comment 9•11 years ago
|
||
Aloha. Let me look at the certificates that AGL has given us so I can figure out what should be blocked.
Status: NEW → ASSIGNED
tracking-firefox25:
+ → ---
tracking-firefox26:
+ → ---
tracking-firefox27:
+ → ---
tracking-firefox28:
+ → ---
Flags: needinfo?(brian)
Target Milestone: --- → 3.15.4
Version: 3.15.3 → trunk
Comment 10•11 years ago
|
||
All, Would it be OK for me to create a separate bug for the actual code changes?
I'm concerned that the content so far in this bug may prevent us from opening it up to the public.
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Kathleen Wilson from comment #10)
> All, Would it be OK for me to create a separate bug for the actual code
> changes?
>
> I'm concerned that the content so far in this bug may prevent us from
> opening it up to the public.
When we created the hidden security bug system, we did so with the promise that security bugs would get opened up. I don't see anything in this bug that would warrant keeping it hidden after we've shipped releases.
![]() |
Reporter | |
Comment 13•11 years ago
|
||
If necessary we could make comment 1 private when we unhide this bug, we should be fine doing all we need to do here.
Comment 15•11 years ago
|
||
According to comment 3, google has blocked "intermediate 1" from the list in the previous comment. I'm attaching a separate copy of that cert.
Updated•11 years ago
|
QA Contact: mwobensmith
Comment 16•11 years ago
|
||
This patch adds a distrust record for "intermediate 1" and inserts it below the root that it chains to.
Comment 17•11 years ago
|
||
Kai, would it better to block intermediate2 instead? From the looks of the certs intermediate 1 is an MITM device. While intermediate 2 (O=DG Tr\xC3\xA9sor, CN=AC DG Tr\xC3\xA9sor SSL) is the one that issued the cert for the MITM and they should be the ones feeling the pain for missisuance. Furthermore we dont know how many other CAs have been signed that have those same properties.
Assignee | ||
Updated•11 years ago
|
Assignee: brian → kaie
Comment 21•11 years ago
|
||
Do we need to assign a CVE here?
Assignee | ||
Comment 22•11 years ago
|
||
(In reply to Camilo Viecco (:cviecco) from comment #17)
> Kai, would it better to block intermediate2 instead? From the looks of the
> certs intermediate 1 is an MITM device. While intermediate 2 (O=DG
> Tr\xC3\xA9sor, CN=AC DG Tr\xC3\xA9sor SSL) is the one that issued the cert
> for the MITM and they should be the ones feeling the pain for missisuance.
> Furthermore we dont know how many other CAs have been signed that have those
> same properties.
This bug isn't about punishing anybody; there will be plenty of discussion regarding that kind of thing on dev.security.policy.
Kai's patch is definitely the least disruptive to end-users, while resolving the issue for the specific intermediate we know about. However, I do think we should acknowledge that there are limitations to the approach here. Obviously, the same entity that mis-issued the Google end-entity certificates could have more certificates, either with different keys, different issuers, different serial numbers, and/or different subject names. Also, the fact that this happened once is good evidence that it has happened or is likely to happen again within the DCSSI hierarchy. If we could find out more information about what the scope of impact would be on blocking one of the higher-level intermediates, we could better consider doing that. However, I suggest we check in Kai's patch now and do the NSS 3.15.4 release, while we try to assemble that information. We can broaden the scope of the blocking as necessary.
Comment 24•11 years ago
|
||
I agree w/Camilo. Why block the MITM device and not the 2nd level intermediate that issued the mis-used intermedate? Going by the subject names they are both the same DG Trésor organization (which appears to be part of the French gov't, http://www.tresor.economie.gouv.fr/, although the cert on that site chains to Certplus, not DCSSI)
Comment 25•11 years ago
|
||
(In reply to Brian Smith from comment #22)
> ... However, I suggest we check in Kai's patch now and do the NSS 3.15.4
> release...
We might actually call it 3.15.3.1
We'll mention it in this bug once it's done.
Comment 26•11 years ago
|
||
I prefer not to work tonight (11 pm at my place right now).
I'm happy to produce the release early in the morning (let me know your deadline by the hour).
I'm happy to land into branches, if you tell me, where you want it.
Since there is ongoing discussion, please get to final agreements what you'd like, and leave clear instructions in this bug which one you want blocked (using the descriptions from comment 14).
If you prefer to distrust an intermediate higher in the chain, no problem, I don't think it needs another review. I'd repeat the tests that Brian demonstrated in comment 19 + 20.
Comment 28•11 years ago
|
||
BTW, my recommendation is that we distrust the intermediate labelled 2, not 1. Intermediate 1 was issued to be placed in a specific MITM device. We don't know how many more devices there are out there. And if the controllers of the device have control of intermediate 2, which they used to create 1, then they can just create a replacement for it as soon as we block, if they choose.
Intermediate 2 is also the SSL intermediate issued from a signature authentication intermediate (3), which seems suspicious and wrong. So I think blocking intermediate 2 is the right choice.
Given the scoping of this cert chain and the ownership of the parts, I think it is highly unlikely that blocking 2 will have significant collateral damage outside the French government, and maybe not even inside.
Gerv
Comment 29•11 years ago
|
||
The DGTPE distributes some certs from here: http://crl2.dgtpe.fr/ .
* "AC de signature et authentification de la DGTPE" is sub3.
* "AC racine de la DGTPE" is sub4.
* "AC racine du MINEFI" has the same public key modulus as sub5, but is self-signed, whereas sub5 is signed by the DCSSI. I presume therefore that sub5 is a cross-cert used to provide public trust to the otherwise-untrusted MINEFI root.
sub3, labelled as for signature authentication, has the following EKU:
X509v3 Key Usage: critical
Certificate Sign, CRL Sign
:-|
Gerv
Comment 30•11 years ago
|
||
Revocation:
End-Entity: no CRL or OCSP
Sub1: no CRL or OCSP
Sub2: no CRL or OCSP
Sub3: CRL: no revoked certificates
Sub4: CRL: no revoked certificates
Sub5: CRL: 1 revoked certificate; serial number (37D7BC5B) does not match Sub4.
Root CA: no CRL or OCSP
Gerv
Comment 31•11 years ago
|
||
Gerv: lack of OSCP and CRL was an issue when DCSSI was first going through the inclusion process according to the old bug. This morning Camilo checked one of their CRLs (not sure which one) and it had a 2011 date and a next update in 2014. Doesn't really sound like it was taken seriously.
Comment 33•11 years ago
|
||
Dan is referring to bug 368970.
Gerv
Comment 34•11 years ago
|
||
expanding comment 30:
intermediate 1: No CRL URL
intermediate 2: No CRL URL
intermediate 3: http://crl1.dgtpe.fr/AC_Racine_DGTPE.crl -> Last Update: Sep 9 09:28:02 2011 GMT; Next Update: Sep 13 09:28:02 2014 GMT (no revoked certs) (3 years between updates)
intermeduate 4: http://www.icp.minefi.gouv.fr/ac-racine.crl -> Last Update: Jun 4 00:00:00 2013 GMT; Next Update: Jun 4 00:00:00 2015 GMT. (2 years between updates).
intermeiate 5: URI:http://www.icp.minefi.gouv.fr/igca.crl -> Last Update: Dec 1 09:00:00 2013 GMT; Next Update: Jan 8 09:00:00 2014 GMT (finaly something that seems to be at least working).
Camilo
Assignee | ||
Comment 35•11 years ago
|
||
Lack of OCSP and CRL in anything except the end-entity certificate doesn't mean much for Firefox because we basically never check those for revocation anyway.
However, Gerv has made a very good point that the most immediate intermediate, labeled "intermediate 1" in comment 14, was probably self-issued within the organization that controls the intermediate labeled "2" in comment 14: The French Treasury office, since both of them refer to "Trésor" in their subject DNs. Also, I found https://www.tresor.economie.gouv.fr/, a public website, which doesn't even chain to DCSSI. So, I think that it makes sense to block the "2" intermediate instead of the first intermediate, according to the logic in comment 28.
So, I will prepare a new patch.
Assignee: kaie → brian
Assignee | ||
Comment 36•11 years ago
|
||
Distrust "intermediate 2", CN="AC DG Tresor SSL"
I ran the vfychain commands above and they gave the same results. I also ran:
vfychain -u 3 -a 2.crt -a 3.crt -a 4.crt -a 5.crt -a 6.crt
vfychain -p -u 3 -a 2.crt -a 3.crt -a 4.crt -a 5.crt -a 6.crt
vfychain -pp -u 3 -a 2.crt -a 3.crt -a 4.crt -a 5.crt -a 6.crt
vfychain -u 3 -a 3.crt -a 4.crt -a 5.crt -a 6.crt
vfychain -p -u 3 -a 3.crt -a 4.crt -a 5.crt -a 6.crt
These resulted in the same results as above:
Chain is bad!
PROBLEM WITH THE CERT CHAIN:
CERT 0. CN=AC DG Trésor SSL,O=DG Trésor,C=FR :
ERROR -8171: Peer's certificate has been marked as not trusted by the user.
However, this command (using libpkix to verify "intermedate 2" as an SSL CA):
vfychain -pp -u 3 -a 3.crt -a 4.crt -a 5.crt -a 6.crt
gives:
Chain is bad!
So, libpkix doesn't provide an error in the verify log for that case only. Not sure why, but I don't think this should block landing this patch.
Attachment #8342768 -
Flags: review?(wtc)
Attachment #8342768 -
Flags: review?(rrelyea)
Updated•11 years ago
|
status-firefox-esr17:
--- → wontfix
status-firefox-esr24:
--- → affected
tracking-firefox26:
--- → +
tracking-firefox27:
--- → +
tracking-firefox28:
--- → +
tracking-firefox-esr24:
--- → 26+
Assignee | ||
Updated•11 years ago
|
Target Milestone: 3.15.4 → 3.15.3.1
Comment 37•11 years ago
|
||
Comment on attachment 8342768 [details] [diff] [review]
distrust-ac-dg-tresor-ssl.patch
r=wtc.
Attachment #8342768 -
Flags: review?(wtc) → review+
Assignee | ||
Comment 38•11 years ago
|
||
I just saw wtc's most recent email on the nss-dev thread. I would have preferred to release this as NSS 3.15.4 instead of NSS 3.15.3.1 but we already got agreement to do NSS 3.15.3.1 and I'd already pushed the patch to the NSS 3.15.3 release branch, so let's stick to the plan we agreed to previously. From now on, we can do things the new way.
Attachment #8342847 -
Flags: review?(wtc)
Attachment #8342847 -
Flags: review?(rrelyea)
Attachment #8342847 -
Flags: review?(kaie)
Assignee | ||
Updated•11 years ago
|
Attachment #8342768 -
Flags: review?(rrelyea)
Assignee | ||
Comment 39•11 years ago
|
||
This is:
$ python client.py --repo=<path-to-nss> update_nss NSS_3_15_3_1_RTM
$ hg commit -m "Update to NSS 3.15.3.1 (NSS_3_15_3_1_RTM), r=me, a=lsblakk"
Attachment #8342850 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #8342850 -
Attachment description: update-to-NSS-3.15.3.1.patch → mozilla-beta: Update to NSS 3.15.3.1
Assignee | ||
Comment 40•11 years ago
|
||
Comment on attachment 8342768 [details] [diff] [review]
distrust-ac-dg-tresor-ssl.patch
default: http://hg.mozilla.org/projects/nss/rev/5a7944776645
NSS_3_15_3_RELEASE_BRANCH: http://hg.mozilla.org/projects/nss/rev/0185cbadb166
Attachment #8342768 -
Flags: checked-in+
Assignee | ||
Comment 41•11 years ago
|
||
Comment on attachment 8342847 [details] [diff] [review]
release-numbering.patch
update NSS versions: http://hg.mozilla.org/projects/nss/rev/fb769b6652a2
tag NSS_3_15_3_1_RTM: http://hg.mozilla.org/projects/nss/rev/5dcf1ad7a98f
Attachment #8342847 -
Flags: checked-in+
Comment 42•11 years ago
|
||
We'll need to land this to mozilla-release branch so we can do a build #2 of FF26.0 RC first thing in the morning. a=me if someone comes around who can do this in a different timezone, otherwise will check in early tomorrow.
Comment 43•11 years ago
|
||
(In reply to Lukas Blakk [:lsblakk] from comment #42)
> We'll need to land this to mozilla-release branch so we can do a build #2 of
> FF26.0 RC first thing in the morning. a=me if someone comes around who can
> do this in a different timezone, otherwise will check in early tomorrow.
cc'ing ryan, not sure if also this stuff
Assignee | ||
Comment 44•11 years ago
|
||
Assignee | ||
Comment 45•11 years ago
|
||
Landed on mozilla-central and mozilla-aurora with the update to NSS 3.15.4 beta 7:
https://bugzilla.mozilla.org/show_bug.cgi?id=898431#c45
Assignee | ||
Comment 46•11 years ago
|
||
Comment 47•11 years ago
|
||
Comment on attachment 8342847 [details] [diff] [review]
release-numbering.patch
Unfortunately this didn't increment the version number of the internal root module.
Some software vendors package the contents of the root module (contents of file certdata.txt) independently from the rest of NSS (e.g. Fedora ships a package ca-certificates), and therefore a unique identifier is required.
Comment 48•11 years ago
|
||
Unfortunately the NSS_3_15_3_1_RTM tag has already been created :(
This patch isn't a functional change, but I'd like to include it in the NSS release to avoid ambiguities.
Can I delete and recreate the NSS release tag?
Comment 49•11 years ago
|
||
Comment on attachment 8342958 [details] [diff] [review]
supplemental release numbering patch (root module version) for release branches
Checked in to NSS 3.15.3 release branch:
https://hg.mozilla.org/projects/nss/rev/e826416013cc
Attachment #8342958 -
Flags: checked-in+
Comment 50•11 years ago
|
||
Comment on attachment 8342847 [details] [diff] [review]
release-numbering.patch
This is fine, but insufficient (see my comments about the root module version).
r=kaie
Attachment #8342847 -
Flags: review?(kaie) → review+
Comment 51•11 years ago
|
||
(In reply to Brian Smith (:briansmith, was :bsmith; Please NEEDINFO? me if you want a response) from comment #44)
> https://hg.mozilla.org/releases/mozilla-release/rev/b760f9a3469f
a+ to uplift to b2g26? We're not auto-merging now that Fx26 is off m-b.
Flags: needinfo?(lsblakk)
Comment 52•11 years ago
|
||
Comment on attachment 8342958 [details] [diff] [review]
supplemental release numbering patch (root module version) for release branches
Pushed to esr24 and release branches:
https://hg.mozilla.org/releases/mozilla-esr24/rev/f00201c126c9
https://hg.mozilla.org/releases/mozilla-release/rev/a79174df6ea3
Also pushed to NSS 3.15.3 release branch:
https://hg.mozilla.org/projects/nss/rev/e826416013cc
Comment 53•11 years ago
|
||
I'm attaching an updated version of Brian's patch for mozilla-beta, which has one added change, the root module version number update.
Attachment #8342850 -
Attachment is obsolete: true
Updated•11 years ago
|
blocking-b2g: --- → koi+
status-b2g-v1.2:
--- → affected
Comment 55•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/7a0b5d1f3e6e
This has Kai's follow-up folded in.
Assignee | ||
Comment 56•11 years ago
|
||
Update configure.in to require NSS 3.15.3.1:
https://hg.mozilla.org/releases/mozilla-esr24/rev/366323a872a7
blocking-b2g: koi+ → ---
status-b2g18:
? → ---
status-b2g-v1.1hd:
? → ---
status-b2g-v1.2:
fixed → ---
Comment 57•11 years ago
|
||
Probably should have updated release to require 3.15.3.1, too. Too late for that I guess (builds have started). the Beta and Release repos still use 3.15 as the minimum. Aurora uses 3.15.4
Comment 58•11 years ago
|
||
Snippets of emails from DCSSI...
First response:
Thank you for your email. We take very seriously the potential risks of misuse of certificate in the IGC/A CA hierarchy.
We have been looking into the issue since we received the first notification from Google.
We will let you know as soon as we have something to report.
Later response:
This anomaly has not for origin an attack but an infortunate and unacceptable configuration - as it is prohibited by our certification policy - that our teams and the concerned actors are at the moment handling : revocation and removal of the concerned CA.
Gerv has also had a couple of phone calls with them, regarding their findings and progress.
Comment 59•11 years ago
|
||
From DCSSI:
following our previous message, please find below the actions we have engaged in order to fullfill back the security policy of the IGC/A :
At 10:30 am (UTC+1), a revocation has been requested...
An updated CRL is available at the following url : http://crl1.dgtpe.fr/
In the afternoon, technical teams deleted inconsistent certificates and their associated keys on the equipments they were installed in. The whole key pairs (public and private keys) associated to the certificates were thus deleted.
As a precautionary measure and to ensure the security if the generated certificates are still present in the navigators, it was asked that the control capability of the LCR be activated on the clients - all clients behind the targeted proxy -.
Comment 60•11 years ago
|
||
Note: DCSSI have indicated that they have revoked at the second intermediate. I'll be updating Chrome's block to reflect that.
Updated•11 years ago
|
blocking-b2g: --- → koi+
status-b2g18:
--- → ?
status-b2g-v1.1hd:
--- → ?
status-b2g-v1.2:
--- → fixed
Comment 61•11 years ago
|
||
I spoke to a representative of DCSSI twice this morning French time, which is what prompted the emails from which Kathleen has quoted. I now also have contact info for Stephane Dubreuil, the head of their response team, and their team email alias has been CCed on this bug.
I think we are taking the correct immediate steps - there seems to be consensus between us, DCSSI and Chrome on which cert to block right now. At some point, we will need to release an appropriate statement, and after that, consider what additional action, if any, would be appropriate.
Regarding revocation, I would expect to see sub2 appear on the CRL for sub3, which is http://crl1.dgtpe.fr/AC_Racine_DGTPE.crl . However, at time of writing, this CRL still says "no revoked certificates". And it still has Last Update and Next Update times which are 3 years apart (Sept 2011 and Sept 2014).
Gerv
Updated•11 years ago
|
Attachment #8342847 -
Flags: review?(wtc) → review+
Comment 62•11 years ago
|
||
Gerv: after a:
wget http://crl1.dgtpe.fr/ac-racine.crl && wget http://crl1.dgtpe.fr/AC_Racine_DGTPE.crl && wget http://crl1.dgtpe.fr/AC_DGTPE_Signature_Authentification.crl && wget http://crl1.dgtpe.fr/AC_DGTPE_Chiffrement.crl
(get all their certs) and a
ls *.crl|sort|xargs -I % openssl crl -text -inform der -in % |grep -A 4 -iP 'update|31da7'
>
Last Update: Dec 5 14:55:02 2013 GMT
Next Update: Dec 12 14:55:02 2013 GMT
CRL extensions:
X509v3 Authority Key Identifier:
keyid:E9:DB:90:8F:FD:5B:99:E4:15:3B:F0:62:5C:A7:E4:0D:58:E8:87:99
--
Serial Number: 031DA7
Revocation Date: Dec 5 09:26:54 2013 GMT
CRL entry extensions:
X509v3 CRL Reason Code:
Cessation Of Operation
you can see that the intermediate 2 is correctly revoked by int3 however this seems of little use as intermediate2 (the one we blocked) had no CRLDP. And thus clients have no mechanism to check for this revocation. Only the crls:
AC_DGTPE_Chiffrement.crl and AC_DGTPE_Signature_Authentification.crl have changed as of a few minutes ago.
Updated•11 years ago
|
Attachment #8342958 -
Flags: review+
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Whiteboard: [adv-main26+][adv-esr24.2+]
Updated•11 years ago
|
Severity: normal → critical
Priority: -- → P1
Comment 63•11 years ago
|
||
Camilo is helping me verify this on Fx26, and he noticed something unexpected that he is looking into.
Comment 64•11 years ago
|
||
Given the contained nature of this incident the initial sec-critical guess is a little overstated. Appropriate when we thought we might have a hacked CA or bogus Google certs on the open internet. I'm lowering this to sec-high which is our more normal rating for compromise of user data.
Keywords: sec-critical → sec-high
Comment 65•11 years ago
|
||
Comment on attachment 8342847 [details] [diff] [review]
release-numbering.patch
belated r+.
Attachment #8342847 -
Flags: review?(rrelyea) → review+
Comment 66•11 years ago
|
||
:juanb, :camilo: what did you find out?
Gerv
Comment 67•11 years ago
|
||
Comment on attachment 8343045 [details] [diff] [review]
mozilla-beta: Update to NSS 3.15.3.1 and fix the root module version number [beta26 already covered]
I realize this patch is unnecessary, because version 26 had already been uplifted to the mozilla-release branch, meaning the current contents of beta 26 are obsolete... And beta will soon get the uplift to 27.
Attachment #8343045 -
Attachment description: mozilla-beta: Update to NSS 3.15.3.1 and fix the root module version number → mozilla-beta: Update to NSS 3.15.3.1 and fix the root module version number [beta26 already covered]
Comment 68•11 years ago
|
||
Can we make this bug public now?
Comment 69•11 years ago
|
||
Kathleen: I think the leaf certificate and the first intermediate contain strings that give details that should be kept confidential, if possible.
Comment 70•11 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #66)
> :juanb, :camilo: what did you find out?
>
> Gerv
To verify it manually Camilo had suggested something like:
- Import the certificates, one by one, top to bottom, except the last one (the root)
- Go to Options/Advanced/Certificates/View Certificates and select the Authorities tab
- Scroll down and select the certificate under "DG Trésor" and click on View
We had not expected to see an entry in the "This certificate has been verified for the following uses:" field set to SSL Certificate Authority, but that's what we saw in both Fx26b10 and Fx26RCb2 (the one with the fix).
We consulted with briansmith who said this was due to bug 829677, but that it was only a problem of showing this information about the certificate vs actually it being valid, and that users were not at risk.
Comment 71•11 years ago
|
||
(In reply to Kathleen Wilson from comment #68)
> Can we make this bug public now?
Shouldn't we release first?
Comment 72•11 years ago
|
||
I ran the same tests in vfychain that Brian did in comment 19 and confirmed that the cert has been explicitly untrusted, in FF 24.2.0esr, 26, 27 and 28.
Assignee | ||
Comment 73•11 years ago
|
||
This is the certificate chain information that Adam Langley publicly shared here:
https://www.imperialviolet.org/binary/anssi-chain.txt
Adam: Thank you very much for sharing the complete certificate chains, and thanks for telling us which certificates you feel comfortable with sharing publicly. I believe I've hidden all the attachments that need to be hidden before the bug is opened up.
Comment 74•11 years ago
|
||
Brian: sadly the vendor that the French government are using for filtering and the location of one of their offices are scattered in the comments on this bug. See #3, #14, #18-20, 23, 27, 32.
Comment 75•11 years ago
|
||
Doesn't Microsoft's security advisory already publish this info?
http://technet.microsoft.com/en-us/security/advisory/2916652
Comment 76•11 years ago
|
||
Kathleen: I don't believe so, unless there's something inside the update itself.
Comment 77•11 years ago
|
||
(In reply to Kathleen Wilson from comment #75)
> Doesn't Microsoft's security advisory already publish this info?
> http://technet.microsoft.com/en-us/security/advisory/2916652
They published the government department involved, but not the device vendor. I don't know why the vendor needs to be private, but then again knowing which of several possible vendors it is doesn't affect our understanding of what we think happened. I've hidden the comments Adam noted in comment 74. The comments were mostly procedural or extracts from the various keys and don't alter an understanding of the timeline, but losing comment 27 hurts a bit. I'll reproduce a sanitized version below:
(Gervase Markham [:gerv] from comment #27)
> I am currently, conveniently, in France, where it is 11.20pm, and will be
> making urgent enquiries with DCSSI in the morning.
>
> In the mean time, here are some immediate things I have discovered.
>
> end entity cert (b):
> [...]
>
> This certificate was probably issued by an MITM device in the normal course
> of its workings...
>
> intermediate 1:
> [...]
>
> This intermediate probably resides in an MITM device created by [...]
>
> 2:
> Serial Number: 204199 (0x31da7)
> Issuer: C=FR, O=DGTPE, CN=AC DGTPE Signature Authentification
> Subject: C=FR, O=DG Tr\xC3\xA9sor, CN=AC DG Tr\xC3\xA9sor SSL
>
> This intermediate belongs to the Direction Generale (DG) du Tresor - the
> Treasury Department of the French Government. It appears to have been issued
> for SSL use, but from a higher intermediate issued for signature
> authentication.
>
> 3:
> Serial Number: 6 (0x6)
> Issuer: C=FR, O=DGTPE, CN=AC Racine DGTPE
> Subject: C=FR, O=DGTPE, CN=AC DGTPE Signature Authentification
>
> This intermediate belongs to the DGTPE - Direction Générale du Trésor et de
> la Politique Economique (General Directorate of Treasury and Economic
> Policy). Presumably this contains the Treasury Department. According to the
> CN, it is designed to be used for signature authentication.
>
> 4:
> Serial Number: 30:30:30:31:31:31:35:39:38:32:31:36:30:37:35:32
> Issuer: C=FR, O=MINEFI, OU=AGENCE AUTORITE, CN=MINEFI-AUTORITE DE
> CERTIFICATION RACINE
> Subject: C=FR, O=DGTPE, CN=AC Racine DGTPE
>
> This certificate is labelled as the DGTPE Root CA (AC Racine), even though
> it's an intermediate in this chain.
>
> 5:
> Serial Number: 11:21:d1:f6:1f:30:2d:07:1d:f1:03:80:aa:7b:2b:cf:b2:b4
> Issuer: C=FR, ST=France, L=Paris, O=PM/SGDN, OU=DCSSI,
> CN=IGC/A/emailAddress=igca@sgdn.pm.gouv.fr
> Subject: C=FR, O=MINEFI, OU=AGENCE AUTORITE, CN=MINEFI-AUTORITE DE
> CERTIFICATION RACINE
>
> This certificate belongs to MINEFI, the Ministry of Economics, Finance and
> Industry.
>
> root:
> Serial Number: 245102874772 (0x3911451094)
> Issuer: C=FR, ST=France, L=Paris, O=PM/SGDN, OU=DCSSI,
> CN=IGC/A/emailAddress=igca@sgdn.pm.gouv.fr
> Subject: C=FR, ST=France, L=Paris, O=PM/SGDN, OU=DCSSI,
> CN=IGC/A/emailAddress=igca@sgdn.pm.gouv.fr
>
> This root belongs to the DCSSI, Direction Centrale de la Sécurité des
> Systèmes d'Information - the Central Information Systems Security Division
> of the French Government.
>
>
> So here's my current understanding: the DCSSI (root) issued a sub (5) to
> MINEFI, who issued one (4) to the DGTPE, who issued an intermediate (3) for
> signature authentication. Someone decided to use that to issue a sub (2) to
> the Treasury Department for SSL use. They used that to issue another sub (1)
> to put in an MITM device, location unknown. That sub issued the end entity
> certificates as part of its normal MITM operation.
>
> So the next point of investigation is to have a more detailed look at the
> certs and see what the key usage is on that sub ostensibly intended for
> signature authentication.
>
> Gerv
Group: crypto-core-security, core-security
Updated•11 years ago
|
Comment 13 is private:
false
Updated•11 years ago
|
Updated•11 years ago
|
Restrict Comments: true
Updated•11 years ago
|
Restrict Comments: false
You need to log in
before you can comment on or make changes to this bug.
Comment 1
•