Closed Bug 946353 Opened 6 years ago Closed 6 years ago

Attachments should include can_edit field

Categories

(bugzilla.mozilla.org :: API, defect)

Development
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: erik.bryn, Assigned: dkl)

Details

Currently there isn't a way to tell if the current authenticated user can edit an attachment. This is needed by the prototype Ember frontend.

I'd like it if you could add a can_edit field to the attachments response in Ember.bug and Bug.attachments.
Are there field-level permissions for attachments?
After talking to glob, I verified that attachments can either be edited or not by a user. If they're the original uploader or the user has editbugs the attachment can be edited.

Sounds like including a `can_edit` field in each attachment is the way to go.
I have committed this function for testing on https://bugzilla-dev.allizom.org. Please give it a try.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2-dev
modified extensions/Ember/lib/WebService.pm
Committed revision 8605

dkl
Assignee: nobody → dkl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(erik.bryn)
Looks good in Ember.bug. Can you add it to Bug.attachments as well?
Flags: needinfo?(erik.bryn)
 (In reply to Erik Bryn from comment #4)
> Looks good in Ember.bug. Can you add it to Bug.attachments as well?

I am going to close this and add the can_edit attribute as part of bug 946457 where Ember.attachments is being created.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified extensions/Ember/lib/WebService.pm
Committed revision 9178. 

dkl
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.