946382 - RangedPtr::operator* should assert if pointing at the end of the range

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Amazingly it doesn't right now.  Docs are clear that people shouldn't do this.  Let's see if they obeyed.

https://tbpl.mozilla.org/?tree=Try&rev=60127ae99ad9

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8342549 [details] [diff] [review]
Patch

Review of attachment 8342549 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently not: https://tbpl.mozilla.org/php/getParsedLog.php?id=31452114&tree=Try

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8342549 [details] [diff] [review]
Patch

Fixed the apparent issue (in the "Check for an empty string" rev there, landed in inbound), at least going by preliminary results:

https://tbpl.mozilla.org/?tree=Try&rev=c607bc59df84

Retry?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8342549 [details] [diff] [review]
Patch

Review of attachment 8342549 [details] [diff] [review]:
-----------------------------------------------------------------

> Make RangedPtr::operator* assert if the pointer is at the end of its range. NOT REVIEWED YET

I would probably say something like "Make RangedPtr::operator* assert that the pointer is in its range.".

Comment 4

[Jeff Walden [:Waldo]]

With description change:

https://hg.mozilla.org/integration/mozilla-inbound/rev/57197340e1da

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57197340e1da