946395 - Back out bug 881937 which made the panel menu keyboard accessible

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

I've filed a (not necessarily comprehensive) list of bugs documenting where keyboard focus in the panel menu is incomplete or broken; see bug 881937's dependency list. I don't really think we should work on these bugs, but rather back out bug 881937 and focus on other Australis stuff. As I understand it, bug 881937 has always been a nice-to-have. That is, not having it is not a loss compared to pre-Australis.

Comment 1

[Matthew N. [:MattN]]

Marking as P4 as I don't think the average user will run into this. I agree that we should do this though given the time bounds we have for Australis.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Matthew N. [:MattN] from comment #1)
> Marking as P4 as I don't think the average user will run into this.

There's some aesthetic fallout (bug 946287) and bad impact on widgets that deal with focused content (bug 946297) affecting add-ons (since we've already worked around it for our edit controls).

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=32536cd6bb3c

Comment 4

[:Gijs (he/him)]

Comment on attachment 8364432 [details] [diff] [review]
patch

Review of attachment 8364432 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming you get an OK from phlsa. From what I understand UX is still thinking this through.

::: browser/components/customizableui/content/panelUI.js
@@ -143,5 @@
>                                                  "toolbarbutton-icon");
> -
> -      // Only focus the panel if it's opened using the keyboard, so that
> -      // cut/copy/paste buttons will work for mouse users.
> -      let keyboardOpened = aEvent && aEvent.sourceEvent &&

If we're no longer doing this we should stop passing this event (or ugly mocks of it in the tests) around. That should probably be a separate patch to keep things neat, but I'd like it to be done sooner rather than later.

Comment 5

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #4)
> Comment on attachment 8364432 [details] [diff] [review]
> patch
> 
> Review of attachment 8364432 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me assuming you get an OK from phlsa. From what I understand UX is still
> thinking this through.

My take-away from the work week is that we don't have the resources to properly finish keyboard access support (or that it's not enough of a priority to spend the required resources on it) and I'd be surprised if UX people found the current state satisfying, but okay, I'll wait and see.

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/801cab0388a2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/801cab0388a2