946510 - [B2G] [Everything.me] [Pinterest] No search function appears when tapping magnifying glass

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Description:
The magnifying glass icon at the top of the Pinterest page does not respond to taps, preventing search functionality.

Repro Steps:
1) Update Buri to Build ID: 20131204004003
2) Launch the Pinterest app from Everything.me.
3) Tap the magnifying glass icon in the upper right corner and observe the page's reaction.

Actual:
Nothing happens.

Expected:
Some type of search function appears, possibly a search bar.

Environmental Variables
Device: Buri 1.2 commercial RIL
Build ID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/758f3fb32dda
Gaia: 8d762f3376318fd6be390432db750ae4904c9ab6
Platform Version: 26.0
RIL Version: 01.02.00.019.102

Notes:
Also repros on Leo 1.1 mozilla RIL
Repro frequency: 100%

Comment 1

[Mike Taylor [:miketaylr]]

A look through their mobile.js file reveals some problems that should be easy to fix. (The root of the problem for the reported issue is in the 3rd bullet point.)

* https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L20, Firefox for Android (but not FxOS) will match their Android regex and fall down some sketchy codepaths later on (e.g., [1]). They could fix this by adding a space after the android token, indexOf("android "). Or matching via a regex like /android[^;]/ might be safer and more obvious. 

* https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L182-L188: "Webkit" (iOS?) and IE10 get transforms, anything else doesn't. For some reason Android doesn't count as WebKit.

* https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L508-L512 is the root of the problem for the search dropdown not working. `this.pixels` is null for non-IE browsers, so we enter the condition that only sets -webkit- and -ms- transforms without a prefixless variant. The same is true in https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L533-L537 for the hide method.

* https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L611 only tests for -webkit- and -ms- prefixes.

[1] https://gist.github.com/miketaylr/8017405#file-mobile_924b62ff-js-L191-L195

Comment 2

[Adam Stevenson [:adamopenweb]]

Might not be easy to make contact, tried submitting a survey in the help section. Having a business account would likely help.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

beltzner - Another Pinterest issue on Firefox OS. Can you help us push this one forward?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm not sure if we updated the JS, but we're in the middle of rolling out a large site update. I'll test this locally and get back to you in this bug.

Comment 5

[Mike Taylor [:miketaylr]]

Looks like the update fixed the issue. Clicking on the magnifying glass icon takes me to pinterest.com/categories/ and there's a search box that is working. Thanks!