Closed Bug 946517 Opened 11 years ago Closed 11 years ago

[build] Provide an environment variable or mozconfig switch to disable ProGuard

Tracking

(Not tracked)

Status:

RESOLVED FIXED

Milestone:

Firefox 29

People

(Reporter: rnewman, Unassigned)

References

Details

Attachments

(1 file, 6 obsolete files)

Provide MOZ_DISABLE_PROGUARD envvar to disable ProGuard (r=rnewman) 11 years ago Lucas Rocha (:lucasr) 1.32 KB, patch	gps : review+	Details \| Diff \| Splinter Review
Bug 942231 - Remove unused member from HomePager (r=margaret) 11 years ago Lucas Rocha (:lucasr) 936 bytes, patch		Details \| Diff \| Splinter Review
Bug 942231 - Factor out HomePager's adapter into a separate file (r=margaret) 11 years ago Lucas Rocha (:lucasr) 15.15 KB, patch		Details \| Diff \| Splinter Review
Bug 942231 - Use 'page' terminology in HomePager instead of 'tab' (r=margaret) 11 years ago Lucas Rocha (:lucasr) 9.39 KB, patch		Details \| Diff \| Splinter Review
Bug 942231 - Keep showHomePager* method together in BrowserApp (r=margaret) 11 years ago Lucas Rocha (:lucasr) 1.53 KB, patch		Details \| Diff \| Splinter Review
Bug 942231 - Define constant with default value for 'can load' hint (r=margaret) 11 years ago Lucas Rocha (:lucasr) 1.73 KB, patch		Details \| Diff \| Splinter Review
Bug 942231 - Change HomePager to be backed by HomeConfig (r=margaret) 11 years ago Lucas Rocha (:lucasr) 42.35 KB, patch		Details \| Diff \| Splinter Review

Richard Newman [:rnewman]

Reporter

Description

•

11 years ago

Might be as simple as checking for PROGUARD_PASSES in the environment before setting it in Makefile.in.

Lucas Rocha (:lucasr)

Comment 1

•

11 years ago

Attached patch Provide MOZ_DISABLE_PROGUARD envvar to disable ProGuard (r=rnewman) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 2

•

11 years ago

Comment on attachment 8343015 [details] [diff] [review] Provide MOZ_DISABLE_PROGUARD envvar to disable ProGuard (r=rnewman) A MOZ_DISABLE_PROGUARD envvar feels more intuitive to me.

Attachment #8343015 - Flags: review?(rnewman)

Richard Newman [:rnewman]

Reporter

Comment 3

•

11 years ago

Comment on attachment 8343015 [details] [diff] [review] Provide MOZ_DISABLE_PROGUARD envvar to disable ProGuard (r=rnewman) 302 to a build peer.

Attachment #8343015 - Flags: review?(rnewman) → review?(gps)

Gregory Szorc [:gps]

Updated

•

11 years ago

Attachment #8343015 - Flags: review?(gps) → review+

Lucas Rocha (:lucasr)

Comment 4

•

11 years ago

https://hg.mozilla.org/integration/fx-team/rev/3c57bafef333

Lucas Rocha (:lucasr)

Comment 5

•

11 years ago

Attached patch Bug 942231 - Remove unused member from HomePager (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 6

•

11 years ago

Attached patch Bug 942231 - Factor out HomePager's adapter into a separate file (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 7

•

11 years ago

Attached patch Bug 942231 - Use 'page' terminology in HomePager instead of 'tab' (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 8

•

11 years ago

Attached patch Bug 942231 - Keep showHomePager* method together in BrowserApp (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 9

•

11 years ago

Attached patch Bug 942231 - Define constant with default value for 'can load' hint (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Comment 10

•

11 years ago

Attached patch Bug 942231 - Change HomePager to be backed by HomeConfig (r=margaret) (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344694 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344695 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344696 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344698 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344699 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Updated

•

11 years ago

Attachment #8344700 - Attachment is obsolete: true

Ryan VanderMeulen [:RyanVM]

Comment 11

•

11 years ago

https://hg.mozilla.org/mozilla-central/rev/3c57bafef333

Status: NEW → RESOLVED

Closed: 11 years ago

Resolution: --- → FIXED

Target Milestone: --- → Firefox 29

Nobody; OK to take it and work on it

Assignee

Updated

•

4 years ago

Product: Firefox for Android → Firefox for Android Graveyard

You need to log in before you can comment on or make changes to this bug.