946531 - [B2G][Contacts] An infinite spinner will occur when performing a search on a large number of contacts

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SearchContactslog.txt

Description:
If the user has a large number of contacts and performs a search with letters that do not match any contacts, an infinite spinner will occur. The user will not be prompted with the message "No contacts found".

Repro Steps:
1)  Updated Buri to Build ID: 20131126004001
2)  Ensure the test phone has 2000 contacts on it.
3)  Tap on the "Contacts app" icon.
4)  Tap on the "Search bar".
5)  Enter in a series of letters that do not match any contacts. 

Actual:
An infinite spinner will occur. The user is never prompted the message "No contacts found".

Expected:
The user is prompted "No contacts found" in a reasonable time frame.

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20131126004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/21e2ad082d85
Gaia: 264c6044b941437ac3c4b28fe4ca392d2bc78445
Platform Version: 26.0
RIL Version: 01.02.00.019.102 

Notes:
Repro frequency: 100%
See attached: video, logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SearchingContacts.mp4

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

I could not reproduce this issue on Leo v 1.1.0 COM RIL

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131205041342
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/05117f42088f
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
RIL Version: 01.01.00.019.281 

The infinite spinner did not occur and the user was prompted "No contacts found".

Comment 4

[Sarah Parsons]

I think this issue is related to bug 945948. To reproduce this issue, it requires the user to scroll through a large amount of contacts. 

This issue started to occur on the Buri 1.2 Build ID: 20131025004000

Gaia   606517ceafe0950c2b89822d5f13353743334f2c
SourceStamp 5eabd267ef04
BuildID 20131025004000
Version 26.0a2

Last working Buri 1.2 Build ID: 20131024004000

Gaia   c57951d06f6c9fa5a762d151e4c75214b988679f
SourceStamp ed279034d066
BuildID 20131024004000
Version 26.0a2

Comment 5

[Jason Smith [:jsmith]]

Minor regression, don't need to block.

Comment 6

[Peter Dolanjski [:pdol]]

Wilfred, can you add this to your backlog?  It doesn't look to be high priority, but we should fix it at some point.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

ni? Francisco 
can you take a look and see how much effort / risk is involved in fixing this bug?
this will help with the triage decision
thanks

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

This shouldn't be hard to resolve.

My guess is that we don't know when we finished loading all contacts and don't stop the spinner cause of this.

Not pretty risky, IMHO, asking Ben for a second opinion here since he implemented it.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

It should stop after the load completes due to this code:

  https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/views/search.js#L335
  https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/views/list.js#L220
  https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/views/list.js#L1065

Its possible we hit an error and |loading| is never set to false, though.  You could try adding code here to do that:

  https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/views/list.js#L1068

Or its possible the app never gets the end of the list due to an error in the gecko API layer.

Comment 10

[Noemí Freire (:noemi)]

Triage: qawanted to check the current steps to reproduce and if it is still occuring in the way reported before taking a decision on this. Thanks!

Comment 11

[Lionel Mauritson]

After checking on 1.2 and 1.4 the search eventually finishes, though it can take a significant amount of time.

1) Added 2000 contacts using a script (./makeReferenceWorkload.sh x-heavy)
2) Gave contacts time to load (Enter dialer -> call log to force load them)
3) Opened contacts app and searched for "fghhh"
4) The loading spinner appears and stays for up to a minute. 
>> Eventually the "No contacts found" message appears.
>> Subsequent searches are faster.

1.2 Environmental Variables:
Device: Buri 1.2 COM
BuildID: 20140220004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2ea6a65eea23
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: v1.2-device.cfg

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140224040201
Gaia: ffb527b84594396ed611edf0a8a5a130d60a742f
Gecko: 31113754db3b
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

This is a known issue, current search is based on DOM, which means we need to wait till the whole list has been rendered, and we know that takes a while.

Ben already pointed out in comment #9, since there are some other bugs like bug #975680 to try to mitigate our time to load from the list (well, this bug will make the way search works change), and other performance bug, will suggest to close this as a proper bug, and create a new one for improving the performance of the search.

Thanks
F.