946541 - Skia doesn't purge GPU resources properly

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Attachment: And the right patch this time.

Comment 3

[Andreas Gal :gal]

This probably blocks any FFOS release that uses skiaGL.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eb7a2bcb3e6f

Please include commit information in your patches. It makes it much easier for those checking in on your behalf.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb7a2bcb3e6f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e9a625ce5d6b

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Do we know how much of an improvement this is? This patch is certainly correct, but I would've thought that textures are the overwhelming majority of stuff that would be freed here...

Comment 8

[Andreas Gal :gal]

I didn't do any representative measurements. All I can say is that this patch makes things visibly better. Also, I can confirm that its definitely not enough. Skia is still hanging on to a bunch of gray matter.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Andreas Gal :gal from comment #8)
> I didn't do any representative measurements. All I can say is that this
> patch makes things visibly better. Also, I can confirm that its definitely
> not enough. Skia is still hanging on to a bunch of gray matter.

SkiaGL is definitely going to take more memory than software. The GLContext (and underlying EGL context) and triple-buffered SurfaceStream alone could account for a few megs. Do we have any idea how much we need to get rid of before things will work?

Maybe instead of purging the GL resources on memory pressure we should just demote it to software. Performance is going to suck anyway if we're constantly dumping the texture cache.