Closed Bug 946547 Opened 6 years ago Closed 6 years ago

Change TestConstants package to org.mozilla.gecko.tests

Categories

(Firefox for Android :: Testing, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file, 1 obsolete file)

For some reason, it is org.mozilla.gecko, despite being in the mobile/android/base/tests/ dir.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment on attachment 8343918 [details] [diff] [review]
Change TestConstants package to org.mozilla.gecko.tests.

Review of attachment 8343918 [details] [diff] [review]:
-----------------------------------------------------------------

Package change looks fine, but I think all of the imports you have here are redundant since TestConstants is in the same package as the files importing it.
(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Package change looks fine, but I think all of the imports you have here are
> redundant since TestConstants is in the same package as the files importing
> it.

You are correct.
Attachment #8344044 - Flags: review?(bnicholson)
Attachment #8343918 - Attachment is obsolete: true
Attachment #8343918 - Flags: review?(bnicholson)
Attachment #8344044 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/445cafa077dc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.