Closed
Bug 946547
Opened 12 years ago
Closed 12 years ago
Change TestConstants package to org.mozilla.gecko.tests
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file, 1 obsolete file)
|
1.88 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
For some reason, it is org.mozilla.gecko, despite being in the mobile/android/base/tests/ dir.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8343918 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8343918 [details] [diff] [review]
Change TestConstants package to org.mozilla.gecko.tests.
Review of attachment 8343918 [details] [diff] [review]:
-----------------------------------------------------------------
Package change looks fine, but I think all of the imports you have here are redundant since TestConstants is in the same package as the files importing it.
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Package change looks fine, but I think all of the imports you have here are
> redundant since TestConstants is in the same package as the files importing
> it.
You are correct.
Attachment #8344044 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8343918 -
Attachment is obsolete: true
Attachment #8343918 -
Flags: review?(bnicholson)
|
|
||
Updated•12 years ago
|
Attachment #8344044 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•