Closed Bug 946583 Opened 11 years ago Closed 10 years ago

Australis: Video DownloadHelper's status bar icon no longer responds to clicks

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cpeterson, Unassigned)

References

()

Details

(Keywords: addon-compat, Whiteboard: [Australis:P-])

STR:
1. Install "Video DownloadHelper" addon: https://addons.mozilla.org/en-US/firefox/addon/video-downloadhelper/
2. An addon icon will be added to the Australis addon bar
3. Click the icon

EXPECTED:
The Video DownloadHelper preferences dialog should open.

RESULT:
Nothing happens.
Blocks: 930788
(In reply to Chris Peterson (:cpeterson) from comment #1)
> 2. An addon icon will be added to the Australis addon bar

What do you mean here? There is no add-on bar in Australis, so either this is another add-on, or you mean the nav-bar, I guess? Please clarify.
Flags: needinfo?(cpeterson)
(In reply to :Gijs Kruitbosch from comment #1)
> What do you mean here? There is no add-on bar in Australis, so either this
> is another add-on, or you mean the nav-bar, I guess? Please clarify.

Sorry, I meant the Australis toolbar (in the space to the right of the AwesomeBar and search box).
Flags: needinfo?(cpeterson)
Component: Toolbars and Customization → Extension Compatibility
Hm, this add-on implement's it's own binding for a menu-button. So I'm assuming it's an issue on the add-on's side.
Component: Extension Compatibility → Add-ons
Product: Firefox → Tech Evangelism
Whiteboard: [Australis:P-]
Tried contacting the developer again. I haven't marked the add-on as incompatible yet because of its massive audience and the available workaround (using the main menu).
Sorry, i completely missed this issue and discover it right now.

I am working on a full rewrite of Video DownloadHelper which probably don't have this issue, but it certainly won't be ready for the launch of 29 as beta, so i need to release another last update of this addon old code base. It's now at the top of my TODO list.
I now have a fix for this button issue on Firefox 29. It can be tested from http://www.downloadhelper.net/install-beta.php?version=4.9.22b1

I could submit version 4.9.22 very soon but i would like to take this opportunity to fix an issue due to a recent youtube change. Is it ok if i submit the new version on Monday ?
My preference is that the Australis bug is fixed as soon as possible. There seems to be close to a million users who will run into this problem soon, and we want the Australis transition to be as smooth as possible.

Having said that, Monday isn't terribly unreasonable.
Can we negociate to Sunday ? :) But i'm not sure an editor will be available to approve the update on Sunday.
Version 4.9.22 is available here: http://www.downloadhelper.net/install-beta.php?version=4.9.22

However, i haven't been able submit it to amo. It failed 3 times at the validating stage: 

"""
Your add-on failed validation with 1 error.

There was a problem contacting the server.
"""

Is there something currently broken on amo ?

I'll try again tomorrow morning.
Still no luck with updating the addon this morning.
This is strange, validation worked after trying from another user profile. Could AdBlockPlus or FlashBlock cause the problem ?

Anyway, the fixed addon is now waiting for review.
The update has been approved on AMO. Thank you, Michel!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.